You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "leosanqing (via GitHub)" <gi...@apache.org> on 2025/12/29 09:33:27 UTC

[PR] [AMORO-4027] Bump shade plugin to fix compilation failure on JDK 17 [amoro]

leosanqing opened a new pull request, #4028:
URL: https://github.com/apache/amoro/pull/4028

   
   ## Why are the changes needed?
   Fix compilation failure on JDK 17
   The latest version is 3.6.1,  Maybe It's fixed in 3.3.0
   https://github.com/apache/maven-shade-plugin/issues/655
   
   Close #4027.
   
   ## Brief change log
   Bump shade plugin from 3.2.4 to 3.6.1
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AMORO-4027] Bump shade plugin to fix compilation failure on JDK 17 [amoro]

Posted by "xxubai (via GitHub)" <gi...@apache.org>.
xxubai merged PR #4028:
URL: https://github.com/apache/amoro/pull/4028


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AMORO-4027] Bump shade plugin to fix compilation failure on JDK 17 [amoro]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4028:
URL: https://github.com/apache/amoro/pull/4028#issuecomment-4270982826

   ## [Codecov](https://app.codecov.io/gh/apache/amoro/pull/4028?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 29.99%. Comparing base ([`cbdc517`](https://app.codecov.io/gh/apache/amoro/commit/cbdc5176b760b2ab46daa5051f29b72f1fee7175?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`26a1a48`](https://app.codecov.io/gh/apache/amoro/commit/26a1a48c3cb85ba7685a62c1e766648eac3c07c4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 106 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4028      +/-   ##
   ============================================
   + Coverage     22.12%   29.99%   +7.86%     
   - Complexity     2461     4075    +1614     
   ============================================
     Files           445      646     +201     
     Lines         40897    51869   +10972     
     Branches       5767     6585     +818     
   ============================================
   + Hits           9050    15556    +6506     
   - Misses        31089    35183    +4094     
   - Partials        758     1130     +372     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/amoro/pull/4028/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [core](https://app.codecov.io/gh/apache/amoro/pull/4028/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `29.99% <ø> (?)` | |
   | [trino](https://app.codecov.io/gh/apache/amoro/pull/4028/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/amoro/pull/4028?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org