You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/05/25 19:17:07 UTC

[GitHub] [calcite] jamesstarr commented on pull request #2385: [CALCITE-1045] Supporting SubQueryRemoveRule for Joins

jamesstarr commented on pull request #2385:
URL: https://github.com/apache/calcite/pull/2385#issuecomment-848194654


   @Zabetak, This PR is focused on handling left joins with correlated queries in ON clauses. 
   
   Joins with correlated queries are rewritten too as join with the right side contain filter node and correlate node to handle the join's filter in SubQueryRemovelRule.  The filter is checked in a loop for correlation ID to handle multiple subqueries.  Right and full outer joins are not rewritten because they would logically be incorrect.  Shifter, a util class in RelBuilder, was moved to RelOptUtil so the existing logic could be used in SubQueryRemoveRule.  RelBuilder also now only considers a join correlated if an ID is provided and actually referenced is found on the right side to the ID.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org