You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2021/02/28 19:50:11 UTC

[GitHub] [avro] tjwp commented on pull request #1102: AVRO-3054: Fix / support decimal logical type in Ruby

tjwp commented on pull request #1102:
URL: https://github.com/apache/avro/pull/1102#issuecomment-787511122


   @andrewthauer Thank you for continuing to push this forward! I've taken a look at this branch, and I created my own branch to work through any additional changes that I would make. I have that commit here if you'd like to take a look: 
   
   https://github.com/tjwp/avro/commit/bdb64e658750e58ecdc8e659195cb39df41dbb55
   
   The main change is to bring the validation of the decimal logical type forward to when the schema is parsed. That way errors with a schema are caught prior to any encoding/decoding. Please take a look and let me know what you think.
   
   As for https://github.com/apache/avro/pull/1082, if you and @ziggythehamster have looked and have no major concerns with it, then I'm happy to move forward.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org