You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by mwkang <gi...@git.apache.org> on 2016/03/23 08:20:04 UTC
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-715]Provide version inf...
GitHub user mwkang opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/792
[ZEPPELIN-715]Provide version information
### What is this PR for?
Provides version information from it's REST api, GUI and command line
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-715
### How should this be tested?
- unit test
- runtime checking
### Screenshots (if appropriate)
- REST API
- GUI
- Command line
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mwkang/incubator-zeppelin ZEPPELIN-715
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/792.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #792
----
commit f5b2e66e8b2aafa4806fdabaec8a31cc3b931eec
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-03-23T01:29:15Z
[ZEPPELIN-715]Provide version information
commit c185a033661454e5a5477785feb5866627971c9f
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-03-23T05:53:33Z
[ZEPPELIN-715]Provide version information (fix style)
commit 1b340042b3a4a0b63de56340533f271ac4f9729c
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-03-23T05:55:52Z
[ZEPPELIN-715]Provide version information (add ASF licenses)
commit d60f41a6d9bc5a927decc3fb2639494c7e12d882
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-03-23T06:02:10Z
[ZEPPELIN-715]Provide version information (add ASF licenses, fix style)
commit d0542277d2b87eab3e51cdcb5779503b5272c789
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-03-23T07:07:35Z
[ZEPPELIN-715]Provide version information
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-715]Provide version inf...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/792#issuecomment-200413978
I have tested and it's working really well.
This is maybe minor, but how about "-v, --version" instead of "-v, -version" for the command line argument?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-715]Provide version inf...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/792#issuecomment-201131454
Thanks for useful feature.
LGTM and merge if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-715]Provide version inf...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/792#issuecomment-200638273
Okay. I changed the command line arguments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-715]Provide version inf...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/792
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---