You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2017/01/25 18:40:32 UTC
Review Request 55949: Styles for showing Config Changes need more
polishing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55949/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-19713
https://issues.apache.org/jira/browse/AMBARI-19713
Repository: ambari
Description
-------
1. When showing diff in the Config Change popup, the content for "Current" vs "New" and "Current" vs "Recommended" columns don't line up properly. See the attached screenshots. The left edge for the content box of "Current" / "Recommended" should be flush with the left edge of the header.
2. The color palette used for the diff looks a bit out of place in that they don't mesh well with the rest of the colors used in Ambari Web. We should use the standard colors that we use elsewhere for warn, alert, success, etc.
Diffs
-----
ambari-web/app/styles/application.less cf84c5b
ambari-web/app/styles/common.less 5541d7c
ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs c53e29d
ambari-web/app/templates/common/modal_popups/dependent_configs_table.hbs PRE-CREATION
ambari-web/app/views/common/modal_popups/dependent_configs_list_popup.js e8e6df5
Diff: https://reviews.apache.org/r/55949/diff/
Testing
-------
20323 passing (18s)
153 pending
Thanks,
Andriy Babiichuk
Re: Review Request 55949: Styles for showing Config Changes need more
polishing
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55949/#review162999
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On \u042f\u043d\u0432. 25, 2017, 6:40 \u043f.\u043f., Andriy Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55949/
> -----------------------------------------------------------
>
> (Updated \u042f\u043d\u0432. 25, 2017, 6:40 \u043f.\u043f.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-19713
> https://issues.apache.org/jira/browse/AMBARI-19713
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. When showing diff in the Config Change popup, the content for "Current" vs "New" and "Current" vs "Recommended" columns don't line up properly. See the attached screenshots. The left edge for the content box of "Current" / "Recommended" should be flush with the left edge of the header.
> 2. The color palette used for the diff looks a bit out of place in that they don't mesh well with the rest of the colors used in Ambari Web. We should use the standard colors that we use elsewhere for warn, alert, success, etc.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less cf84c5b
> ambari-web/app/styles/common.less 5541d7c
> ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs c53e29d
> ambari-web/app/templates/common/modal_popups/dependent_configs_table.hbs PRE-CREATION
> ambari-web/app/views/common/modal_popups/dependent_configs_list_popup.js e8e6df5
>
> Diff: https://reviews.apache.org/r/55949/diff/
>
>
> Testing
> -------
>
> 20323 passing (18s)
> 153 pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>