You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/15 18:42:08 UTC

[GitHub] [superset] ktmud opened a new pull request #12556: fix(viz): missing groupby for boxplot with distribute by

ktmud opened a new pull request #12556:
URL: https://github.com/apache/superset/pull/12556


   ### SUMMARY
   
   Fix two bugs in Box Plot Viz:
   
   1.  when select "Series" and "Distributed by", `SqalTable` generates invalid SQL queries
      ![image](https://user-images.githubusercontent.com/335541/104763787-4c411800-571b-11eb-9a66-380c1a5f1722.png)
   2. when applying adhoc metrics, post processing fails:
      ![image](https://user-images.githubusercontent.com/335541/104765385-ac38be00-571d-11eb-838b-37cc4334c8b9.png)
   
   Not sure when did these bugs occur, but they seem to be related to either #9366 or #12091 .
   
   Anyway, the related logics in the new chart data API were not robust enough. Both issues were actually fixed in #10270 as well, but I'm creating a separate PR here to fix BoxPlot first.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   See summary for BEFORE.
   
   ### TEST PLAN
   
   Manual verification.
   
   This is a hotfix. I'm going to create a separate task to add tests.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: see SUMMARY
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761182371






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761182371


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=h1) Report
   > Merging [#12556](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=desc) (12b27e7) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.62%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12556/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12556      +/-   ##
   ==========================================
   + Coverage   63.82%   66.44%   +2.62%     
   ==========================================
     Files         486     1015     +529     
     Lines       29958    49614   +19656     
     Branches        0     4839    +4839     
   ==========================================
   + Hits        19120    32967   +13847     
   - Misses      10838    16524    +5686     
   - Partials        0      123     +123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.99% <ø> (?)` | |
   | javascript | `60.73% <ø> (?)` | |
   | python | `63.44% <100.00%> (-0.38%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.58% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.86% <100.00%> (+0.20%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.57% <100.00%> (-0.02%)` | :arrow_down: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-2.82%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.55%)` | :arrow_down: |
   | [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
   | [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
   | ... and [535 more](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=footer). Last update [fc5e311...12b27e7](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761141279


   tested LGTM!! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761170093


   Just added one more commit to exclude set `is_timeseries` for QueryObject in samples mode to fix this bug:
   
   ![image](https://user-images.githubusercontent.com/335541/104773333-c24c7b80-5729-11eb-86dd-4d27dfaf1671.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io commented on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761182371


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=h1) Report
   > Merging [#12556](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=desc) (e4565db) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **decrease** coverage by `0.60%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12556/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12556      +/-   ##
   ==========================================
   - Coverage   63.82%   63.21%   -0.61%     
   ==========================================
     Files         486      486              
     Lines       29958    29959       +1     
   ==========================================
   - Hits        19120    18939     -181     
   - Misses      10838    11020     +182     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `63.21% <100.00%> (-0.61%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <100.00%> (-0.45%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.86% <100.00%> (+0.20%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.67% <100.00%> (-0.92%)` | :arrow_down: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.50% <0.00%> (-25.07%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.38% <0.00%> (-6.45%)` | :arrow_down: |
   | ... and [13 more](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=footer). Last update [fc5e311...12b27e7](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761182371


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=h1) Report
   > Merging [#12556](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=desc) (12b27e7) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `7.18%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12556/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12556      +/-   ##
   ==========================================
   + Coverage   63.82%   71.01%   +7.18%     
   ==========================================
     Files         486      529      +43     
     Lines       29958    19667   -10291     
     Branches        0     4839    +4839     
   ==========================================
   - Hits        19120    13966    -5154     
   + Misses      10838     5578    -5260     
   - Partials        0      123     +123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.99% <ø> (?)` | |
   | javascript | `60.73% <ø> (?)` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ions/versions/b46fa1b0b39e\_add\_params\_to\_tables.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iNDZmYTFiMGIzOWVfYWRkX3BhcmFtc190b190YWJsZXMucHk=) | | |
   | [...s/versions/db0c65b146bd\_update\_slice\_model\_json.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kYjBjNjViMTQ2YmRfdXBkYXRlX3NsaWNlX21vZGVsX2pzb24ucHk=) | | |
   | [superset/commands/utils.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | | |
   | [superset/reports/commands/base.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9iYXNlLnB5) | | |
   | [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | | |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | | |
   | [superset/views/utils.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | | |
   | [...817e1c9b09d0\_add\_not\_null\_to\_dbs\_sqlalchemy\_url.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MTdlMWM5YjA5ZDBfYWRkX25vdF9udWxsX3RvX2Ric19zcWxhbGNoZW15X3VybC5weQ==) | | |
   | [superset/errors.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | | |
   | [superset/charts/commands/delete.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | | |
   | ... and [1002 more](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=footer). Last update [fc5e311...12b27e7](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud merged pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #12556:
URL: https://github.com/apache/superset/pull/12556


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761182371


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=h1) Report
   > Merging [#12556](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=desc) (12b27e7) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.85%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12556/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12556      +/-   ##
   ==========================================
   + Coverage   63.82%   66.67%   +2.85%     
   ==========================================
     Files         486     1015     +529     
     Lines       29958    49629   +19671     
     Branches        0     4839    +4839     
   ==========================================
   + Hits        19120    33090   +13970     
   - Misses      10838    16416    +5578     
   - Partials        0      123     +123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.99% <ø> (?)` | |
   | javascript | `60.73% <ø> (?)` | |
   | python | `63.82% <100.00%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.58% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.86% <100.00%> (+0.20%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.58% <100.00%> (ø)` | |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `50.00% <0.00%> (ø)` | |
   | [...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY3NzdGVtcGxhdGVzL0Nzc1RlbXBsYXRlc0xpc3QudHN4) | `78.26% <0.00%> (ø)` | |
   | [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `80.76% <0.00%> (ø)` | |
   | [...perset-frontend/src/middleware/loggerMiddleware.js](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvbG9nZ2VyTWlkZGxld2FyZS5qcw==) | `95.00% <0.00%> (ø)` | |
   | [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `58.00% <0.00%> (ø)` | |
   | [...nd/src/dashboard/util/isInDifferentFilterScopes.js](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzSW5EaWZmZXJlbnRGaWx0ZXJTY29wZXMuanM=) | `66.66% <0.00%> (ø)` | |
   | ... and [522 more](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=footer). Last update [fc5e311...12b27e7](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761182371


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=h1) Report
   > Merging [#12556](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=desc) (12b27e7) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `2.61%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12556/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12556      +/-   ##
   ==========================================
   + Coverage   63.82%   66.44%   +2.61%     
   ==========================================
     Files         486     1015     +529     
     Lines       29958    49629   +19671     
     Branches        0     4839    +4839     
   ==========================================
   + Hits        19120    32974   +13854     
   - Misses      10838    16532    +5694     
   - Partials        0      123     +123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.99% <ø> (?)` | |
   | javascript | `60.73% <ø> (?)` | |
   | python | `63.44% <100.00%> (-0.39%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.58% <100.00%> (+0.07%)` | :arrow_up: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.86% <100.00%> (+0.20%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.58% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-2.82%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.55%)` | :arrow_down: |
   | [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `98.66% <0.00%> (ø)` | |
   | [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <0.00%> (ø)` | |
   | ... and [527 more](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=footer). Last update [fc5e311...12b27e7](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761133839


   Tested locally, and it looks fixed to me!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761121057


   A cleanup PR to fix the root of this problem: https://github.com/apache-superset/superset-ui/pull/901


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761182371


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=h1) Report
   > Merging [#12556](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=desc) (e4565db) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **decrease** coverage by `0.17%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12556/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12556      +/-   ##
   ==========================================
   - Coverage   63.82%   63.65%   -0.18%     
   ==========================================
     Files         486      486              
     Lines       29958    29959       +1     
   ==========================================
   - Hits        19120    19069      -51     
   - Misses      10838    10890      +52     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `63.65% <100.00%> (-0.18%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <100.00%> (-0.45%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.86% <100.00%> (+0.20%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.32% <100.00%> (-0.27%)` | :arrow_down: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.72%)` | :arrow_down: |
   | ... and [12 more](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=footer). Last update [fc5e311...12b27e7](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761182371


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=h1) Report
   > Merging [#12556](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=desc) (12b27e7) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **decrease** coverage by `3.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12556/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12556      +/-   ##
   ==========================================
   - Coverage   63.82%   60.73%   -3.09%     
   ==========================================
     Files         486      529      +43     
     Lines       29958    19648   -10310     
     Branches        0     4839    +4839     
   ==========================================
   - Hits        19120    11934    -7186     
   + Misses      10838     7516    -3322     
   - Partials        0      198     +198     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `60.73% <ø> (?)` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/key\_value.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | | |
   | [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | | |
   | [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | | |
   | [superset/datasets/commands/refresh.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvcmVmcmVzaC5weQ==) | | |
   | [...tions/versions/e9df189e5c7e\_update\_base\_metrics.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lOWRmMTg5ZTVjN2VfdXBkYXRlX2Jhc2VfbWV0cmljcy5weQ==) | | |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | | |
   | [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | | |
   | [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | | |
   | [superset/migrations/versions/d6db5a5cdb5d\_.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kNmRiNWE1Y2RiNWRfLnB5) | | |
   | ... and [1002 more](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=footer). Last update [fc5e311...12b27e7](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761182371


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=h1) Report
   > Merging [#12556](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=desc) (12b27e7) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **increase** coverage by `6.97%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12556/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12556      +/-   ##
   ==========================================
   + Coverage   63.82%   70.79%   +6.97%     
   ==========================================
     Files         486      529      +43     
     Lines       29958    19667   -10291     
     Branches        0     4839    +4839     
   ==========================================
   - Hits        19120    13923    -5197     
   + Misses      10838     5617    -5221     
   - Partials        0      127     +127     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.61% <ø> (?)` | |
   | javascript | `60.73% <ø> (?)` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/filters.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZmlsdGVycy5weQ==) | | |
   | [.../migrations/versions/1a1d627ebd8e\_position\_json.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xYTFkNjI3ZWJkOGVfcG9zaXRpb25fanNvbi5weQ==) | | |
   | [superset/datasets/commands/importers/dispatcher.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL2Rpc3BhdGNoZXIucHk=) | | |
   | [superset/db\_engine\_specs/cockroachdb.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NvY2tyb2FjaGRiLnB5) | | |
   | [...ions/versions/7e3ddad2a00b\_results\_key\_to\_query.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83ZTNkZGFkMmEwMGJfcmVzdWx0c19rZXlfdG9fcXVlcnkucHk=) | | |
   | [superset/queries/schemas.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zY2hlbWFzLnB5) | | |
   | [...migrations/versions/836c0bf75904\_cache\_timeouts.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MzZjMGJmNzU5MDRfY2FjaGVfdGltZW91dHMucHk=) | | |
   | [...s/versions/eca4694defa7\_sqllab\_setting\_defaults.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lY2E0Njk0ZGVmYTdfc3FsbGFiX3NldHRpbmdfZGVmYXVsdHMucHk=) | | |
   | [...ions/versions/956a063c52b3\_adjusting\_key\_length.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy85NTZhMDYzYzUyYjNfYWRqdXN0aW5nX2tleV9sZW5ndGgucHk=) | | |
   | [...rations/versions/e46f2d27a08e\_materialize\_perms.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lNDZmMmQyN2EwOGVfbWF0ZXJpYWxpemVfcGVybXMucHk=) | | |
   | ... and [1002 more](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=footer). Last update [fc5e311...12b27e7](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud edited a comment on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761170093


   Just added one more commit to force `is_timeseries` to false for `QueryObject` in samples mode so time column isn't added to groupby, to fix this bug:
   
   ![image](https://user-images.githubusercontent.com/335541/104773333-c24c7b80-5729-11eb-86dd-4d27dfaf1671.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761182371


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=h1) Report
   > Merging [#12556](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=desc) (e4565db) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **decrease** coverage by `4.73%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12556/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12556      +/-   ##
   ==========================================
   - Coverage   63.82%   59.08%   -4.74%     
   ==========================================
     Files         486      959     +473     
     Lines       29958    46862   +16904     
     Branches        0     4353    +4353     
   ==========================================
   + Hits        19120    27689    +8569     
   - Misses      10838    19173    +8335     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.99% <ø> (?)` | |
   | python | `63.65% <100.00%> (-0.18%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <100.00%> (-0.45%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.86% <100.00%> (+0.20%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.32% <100.00%> (-0.27%)` | :arrow_down: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.72%)` | :arrow_down: |
   | ... and [485 more](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=footer). Last update [fc5e311...12b27e7](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12556: fix(viz): missing groupby and broken adhoc metrics for boxplot

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12556:
URL: https://github.com/apache/superset/pull/12556#issuecomment-761182371


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=h1) Report
   > Merging [#12556](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=desc) (e4565db) into [master](https://codecov.io/gh/apache/superset/commit/fc5e311842b8039da6ae897f53ca2434d893210f?el=desc) (fc5e311) will **decrease** coverage by `4.73%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12556/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12556      +/-   ##
   ==========================================
   - Coverage   63.82%   59.08%   -4.74%     
   ==========================================
     Files         486      959     +473     
     Lines       29958    46864   +16906     
     Branches        0     4353    +4353     
   ==========================================
   + Hits        19120    27691    +8571     
   - Misses      10838    19173    +8335     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.99% <ø> (?)` | |
   | python | `63.65% <100.00%> (-0.17%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <100.00%> (-0.45%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.86% <100.00%> (+0.20%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.32% <100.00%> (-0.27%)` | :arrow_down: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.72%)` | :arrow_down: |
   | ... and [483 more](https://codecov.io/gh/apache/superset/pull/12556/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=footer). Last update [fc5e311...12b27e7](https://codecov.io/gh/apache/superset/pull/12556?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org