[jira] [Commented] (KAFKA-2733) Distinguish metric names inside the sensor registry

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047676#comment-15047676 ] 

ASF GitHub Bot commented on KAFKA-2733:
---------------------------------------

GitHub user guozhangwang opened a pull request:

    https://github.com/apache/kafka/pull/643

    KAFKA-2733: Standardize metric name for Kafka Streams

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guozhangwang/kafka K2733

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/643.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #643
    
----
commit c437400f28c711a89fbab0c9fd179aa817f8c1fb
Author: Guozhang Wang <wa...@gmail.com>
Date:   2015-12-08T23:20:25Z

    v1

----


> Distinguish metric names inside the sensor registry
> ---------------------------------------------------
>
>                 Key: KAFKA-2733
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2733
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Guozhang Wang
>             Fix For: 0.9.0.1
>
>
> Since stream tasks can share the same StreamingMetrics object, and the MetricName is distinguishable only by the group name (same for the same type of states, and for other streaming metrics) and the tags (currently only the client-ids of the StreamThead), when we have multiple tasks within a single stream thread, it could lead to IllegalStateException upon trying to registry the same metric from those tasks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)