[GitHub] [incubator-seatunnel] wuchunfu commented on a diff in pull request #1819: https://github.com/apache/incubator-seatunnel/issues/1818

[GitBox <gi...@apache.org>]

wuchunfu commented on code in PR #1819:
URL: https://github.com/apache/incubator-seatunnel/pull/1819#discussion_r867331397


##########
seatunnel-core/seatunnel-core-spark/src/main/java/org/apache/seatunnel/core/spark/SparkStarter.java:
##########
@@ -191,11 +191,15 @@ private List<Path> getPluginsJarDependencies() throws IOException {
         if (!Files.exists(pluginRootDir) || !Files.isDirectory(pluginRootDir)) {
             return Collections.emptyList();
         }
+        //my test code
+        Path pluginJarPath = Paths.get("/Users/chenhu/projects/org/apache/seatunnel/seatunnel-common/plugins/oracle/lib/ojdbc8.jar");
+

Review Comment:
   This path seems to be problematic, not general enough, please modify it, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org