You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by da...@apache.org on 2024/03/27 06:08:46 UTC

(pulsar) branch master updated: [fix][ml]Expose ledger timestamp (#22338)

This is an automated email from the ASF dual-hosted git repository.

daojun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new cd49defc138 [fix][ml]Expose ledger timestamp  (#22338)
cd49defc138 is described below

commit cd49defc1383175ef32e18c7f0905567f734318c
Author: 道君 <da...@apache.org>
AuthorDate: Wed Mar 27 14:08:39 2024 +0800

    [fix][ml]Expose ledger timestamp  (#22338)
---
 .../org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java | 1 +
 .../org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryTest.java | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
index 51c5c91234f..5ce84b3ed85 100644
--- a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
+++ b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
@@ -694,6 +694,7 @@ public class ManagedLedgerFactoryImpl implements ManagedLedgerFactory {
                     ledgerInfo.ledgerId = pbLedgerInfo.getLedgerId();
                     ledgerInfo.entries = pbLedgerInfo.hasEntries() ? pbLedgerInfo.getEntries() : null;
                     ledgerInfo.size = pbLedgerInfo.hasSize() ? pbLedgerInfo.getSize() : null;
+                    ledgerInfo.timestamp = pbLedgerInfo.hasTimestamp() ? pbLedgerInfo.getTimestamp() : null;
                     ledgerInfo.isOffloaded = pbLedgerInfo.hasOffloadContext();
                     if (pbLedgerInfo.hasOffloadContext()) {
                         MLDataFormats.OffloadContext offloadContext = pbLedgerInfo.getOffloadContext();
diff --git a/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryTest.java b/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryTest.java
index 708fda308b8..a953b140aba 100644
--- a/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryTest.java
+++ b/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryTest.java
@@ -19,6 +19,7 @@
 package org.apache.bookkeeper.mledger.impl;
 
 import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertNotNull;
 
 import java.util.UUID;
 import java.util.concurrent.TimeUnit;
@@ -60,6 +61,10 @@ public class ManagedLedgerFactoryTest extends MockedBookKeeperTestCase {
         assertEquals(info.ledgers.get(2).ledgerId, 5);
         assertEquals(info.ledgers.get(3).ledgerId, 6);
 
+        for (ManagedLedgerInfo.LedgerInfo linfo : info.ledgers) {
+            assertNotNull(linfo.timestamp);
+        }
+
         assertEquals(info.cursors.size(), 1);
 
         CursorInfo cursorInfo = info.cursors.get("c1");