You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/16 11:00:01 UTC
[GitHub] [inlong] healchow opened a new pull request, #5080: [INLONG-5066][Manager] Remove the LightGroup-related workflow listener and definitions
healchow opened a new pull request, #5080:
URL: https://github.com/apache/inlong/pull/5080
### Prepare a Pull Request
- Fixes #5066
### Motivation
Remove the LightGroup-related workflow listener and definitions.
### Modifications
1. Merge `LightGroupXxxListener` into `InitGroupXxxListener` and `UpdateGroupXxxListener`.
2. Merge `XxxLightGroupWorkflowDefinition` into `XxxGroupWorkflowDefinition`.
### Verifying this change
- [x] This change is already covered by existing tests, such as:
`InlongGroupProcessOperationTest`
`CreateGroupWorkflowDefinitionTest`
`WorkflowServiceImplTest`
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on pull request #5080: [INLONG-5066][Manager] Remove the LightGroup-related workflow listener and definitions
Posted by GitBox <gi...@apache.org>.
GanfengTan commented on PR #5080:
URL: https://github.com/apache/inlong/pull/5080#issuecomment-1186472293
@healchow
1.Please added background and benefits of modification.
2.Refactoring design needs to be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5080: [INLONG-5066][Manager] Remove the LightGroup-related workflow listener and definitions
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5080:
URL: https://github.com/apache/inlong/pull/5080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5080: [INLONG-5066][Manager] Remove the LightGroup-related workflow listener and definitions
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5080:
URL: https://github.com/apache/inlong/pull/5080#discussion_r923048038
##########
inlong-manager/manager-service/src/test/java/org/apache/inlong/manager/service/ServiceBaseTest.java:
##########
@@ -17,28 +17,128 @@
package org.apache.inlong.manager.service;
+import org.apache.inlong.manager.common.consts.InlongConstants;
+import org.apache.inlong.manager.common.enums.FieldType;
+import org.apache.inlong.manager.common.enums.GroupStatus;
+import org.apache.inlong.manager.common.enums.MQType;
+import org.apache.inlong.manager.common.pojo.group.InlongGroupInfo;
+import org.apache.inlong.manager.common.pojo.group.none.InlongNoneMqInfo;
+import org.apache.inlong.manager.common.pojo.group.pulsar.InlongPulsarInfo;
+import org.apache.inlong.manager.common.pojo.stream.InlongStreamInfo;
+import org.apache.inlong.manager.common.pojo.stream.InlongStreamRequest;
+import org.apache.inlong.manager.common.pojo.stream.StreamField;
+import org.apache.inlong.manager.service.core.InlongStreamService;
+import org.apache.inlong.manager.service.group.InlongGroupService;
import org.apache.inlong.manager.test.BaseTest;
import org.junit.jupiter.api.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.boot.test.context.SpringBootTest;
+import java.util.ArrayList;
+import java.util.List;
+
/**
* Test class for base test service.
*/
@SpringBootApplication
@SpringBootTest(classes = ServiceBaseTest.class)
public class ServiceBaseTest extends BaseTest {
- private static final Logger LOGGER = LoggerFactory.getLogger(ServiceBaseTest.class);
-
public static final String GLOBAL_GROUP_ID = "global_group";
public static final String GLOBAL_STREAM_ID = "global_stream";
public static final String GLOBAL_OPERATOR = "admin";
+ private static final Logger LOGGER = LoggerFactory.getLogger(ServiceBaseTest.class);
Review Comment:
For reuse code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5080: [INLONG-5066][Manager] Remove the LightGroup-related workflow listener and definitions
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5080:
URL: https://github.com/apache/inlong/pull/5080#discussion_r922950139
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/group/CreateGroupWorkflowDefinition.java:
##########
@@ -41,61 +41,61 @@
public class CreateGroupWorkflowDefinition implements WorkflowDefinition {
@Autowired
- private GroupInitProcessListener groupInitProcessListener;
+ private InitGroupListener initGroupListener;
@Autowired
- private GroupCompleteProcessListener groupCompleteProcessListener;
+ private InitGroupCompleteListener initGroupCompleteListener;
@Autowired
- private GroupFailedProcessListener groupFailedProcessListener;
+ private InitGroupFailedListener initGroupFailedListener;
@Autowired
private GroupTaskListenerFactory groupTaskListenerFactory;
@Override
public WorkflowProcess defineProcess() {
-
// Configuration process
WorkflowProcess process = new WorkflowProcess();
- process.addListener(groupInitProcessListener);
- process.addListener(groupCompleteProcessListener);
- process.addListener(groupFailedProcessListener);
-
- process.setType("Group Resource Creation");
process.setName(getProcessName().name());
+ process.setType(getProcessName().getDisplayName());
process.setDisplayName(getProcessName().getDisplayName());
process.setFormClass(GroupResourceProcessForm.class);
process.setVersion(1);
process.setHidden(1);
+ // Set up the listener
+ process.addListener(initGroupListener);
+ process.addListener(initGroupCompleteListener);
+ process.addListener(initGroupFailedListener);
+
// Start node
StartEvent startEvent = new StartEvent();
process.setStartEvent(startEvent);
- // init MQ
+ // Init MQ
ServiceTask initMQTask = new ServiceTask();
- initMQTask.setName("initMQ");
+ initMQTask.setName("InitMQ");
Review Comment:
Good idea.
I'll change them to Enum in the next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #5080: [INLONG-5066][Manager] Remove the LightGroup-related workflow listener and definitions
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #5080:
URL: https://github.com/apache/inlong/pull/5080#issuecomment-1186680094
@woofyzhao @gong PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] kipshi commented on a diff in pull request #5080: [INLONG-5066][Manager] Remove the LightGroup-related workflow listener and definitions
Posted by GitBox <gi...@apache.org>.
kipshi commented on code in PR #5080:
URL: https://github.com/apache/inlong/pull/5080#discussion_r923007842
##########
inlong-manager/manager-service/src/test/java/org/apache/inlong/manager/service/ServiceBaseTest.java:
##########
@@ -17,28 +17,128 @@
package org.apache.inlong.manager.service;
+import org.apache.inlong.manager.common.consts.InlongConstants;
+import org.apache.inlong.manager.common.enums.FieldType;
+import org.apache.inlong.manager.common.enums.GroupStatus;
+import org.apache.inlong.manager.common.enums.MQType;
+import org.apache.inlong.manager.common.pojo.group.InlongGroupInfo;
+import org.apache.inlong.manager.common.pojo.group.none.InlongNoneMqInfo;
+import org.apache.inlong.manager.common.pojo.group.pulsar.InlongPulsarInfo;
+import org.apache.inlong.manager.common.pojo.stream.InlongStreamInfo;
+import org.apache.inlong.manager.common.pojo.stream.InlongStreamRequest;
+import org.apache.inlong.manager.common.pojo.stream.StreamField;
+import org.apache.inlong.manager.service.core.InlongStreamService;
+import org.apache.inlong.manager.service.group.InlongGroupService;
import org.apache.inlong.manager.test.BaseTest;
import org.junit.jupiter.api.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.boot.test.context.SpringBootTest;
+import java.util.ArrayList;
+import java.util.List;
+
/**
* Test class for base test service.
*/
@SpringBootApplication
@SpringBootTest(classes = ServiceBaseTest.class)
public class ServiceBaseTest extends BaseTest {
- private static final Logger LOGGER = LoggerFactory.getLogger(ServiceBaseTest.class);
-
public static final String GLOBAL_GROUP_ID = "global_group";
public static final String GLOBAL_STREAM_ID = "global_stream";
public static final String GLOBAL_OPERATOR = "admin";
+ private static final Logger LOGGER = LoggerFactory.getLogger(ServiceBaseTest.class);
Review Comment:
why put here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on pull request #5080: [INLONG-5066][Manager] Remove the LightGroup-related workflow listener and definitions
Posted by GitBox <gi...@apache.org>.
healchow commented on PR #5080:
URL: https://github.com/apache/inlong/pull/5080#issuecomment-1186512747
> @healchow 1. Please added background and benefits of modification. 2. Refactoring design needs to be added.
Added in the parent issue, see #5029.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] woofyzhao commented on a diff in pull request #5080: [INLONG-5066][Manager] Remove the LightGroup-related workflow listener and definitions
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on code in PR #5080:
URL: https://github.com/apache/inlong/pull/5080#discussion_r922934846
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/impl/InlongGroupImpl.java:
##########
@@ -129,11 +129,12 @@ public InlongGroupContext init() throws Exception {
}
}
String formDataNew = formDataJson.toString();
- NewGroupProcessForm newGroupProcessForm = JsonUtils.parseObject(
- formDataNew, NewGroupProcessForm.class);
- Preconditions.checkNotNull(newGroupProcessForm, "NewGroupProcessForm cannot be null");
- groupContext.setInitMsg(newGroupProcessForm);
- WorkflowResult startWorkflowResult = workFlowClient.startInlongGroup(taskId, newGroupProcessForm);
+ ApplyGroupProcessForm groupProcessForm = JsonUtils.parseObject(
+ formDataNew, ApplyGroupProcessForm.class);
+ Preconditions.checkNotNull(groupProcessForm, "ApplyGroupProcessForm cannot be null");
+ groupContext.setInitMsg(groupProcessForm);
+ assert groupProcessForm != null;
+ WorkflowResult startWorkflowResult = workFlowClient.startInlongGroup(taskId, groupProcessForm);
Review Comment:
private final WorkflowClient workFlowClient;
I was referring to this member declaration in the class you have modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5080: [INLONG-5066][Manager] Remove the LightGroup-related workflow listener and definitions
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5080:
URL: https://github.com/apache/inlong/pull/5080#discussion_r922933302
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/impl/InlongGroupImpl.java:
##########
@@ -129,11 +129,12 @@ public InlongGroupContext init() throws Exception {
}
}
String formDataNew = formDataJson.toString();
- NewGroupProcessForm newGroupProcessForm = JsonUtils.parseObject(
- formDataNew, NewGroupProcessForm.class);
- Preconditions.checkNotNull(newGroupProcessForm, "NewGroupProcessForm cannot be null");
- groupContext.setInitMsg(newGroupProcessForm);
- WorkflowResult startWorkflowResult = workFlowClient.startInlongGroup(taskId, newGroupProcessForm);
+ ApplyGroupProcessForm groupProcessForm = JsonUtils.parseObject(
+ formDataNew, ApplyGroupProcessForm.class);
+ Preconditions.checkNotNull(groupProcessForm, "ApplyGroupProcessForm cannot be null");
+ groupContext.setInitMsg(groupProcessForm);
+ assert groupProcessForm != null;
+ WorkflowResult startWorkflowResult = workFlowClient.startInlongGroup(taskId, groupProcessForm);
Review Comment:
Yeah, I think so.
But this class belongs to the client module and should change in another single PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on a diff in pull request #5080: [INLONG-5066][Manager] Remove the LightGroup-related workflow listener and definitions
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #5080:
URL: https://github.com/apache/inlong/pull/5080#discussion_r922945287
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/group/listener/InitGroupListener.java:
##########
@@ -15,60 +15,57 @@
* limitations under the License.
*/
-package org.apache.inlong.manager.service.workflow.group.listener.light;
+package org.apache.inlong.manager.service.workflow.group.listener;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.collections.CollectionUtils;
-import org.apache.inlong.manager.common.enums.ErrorCodeEnum;
import org.apache.inlong.manager.common.enums.GroupStatus;
+import org.apache.inlong.manager.common.exceptions.BusinessException;
import org.apache.inlong.manager.common.exceptions.WorkflowListenerException;
import org.apache.inlong.manager.common.pojo.group.InlongGroupInfo;
-import org.apache.inlong.manager.common.pojo.stream.InlongStreamInfo;
-import org.apache.inlong.manager.common.pojo.workflow.form.process.LightGroupResourceProcessForm;
+import org.apache.inlong.manager.common.pojo.workflow.form.process.GroupResourceProcessForm;
import org.apache.inlong.manager.service.group.InlongGroupService;
-import org.apache.inlong.manager.service.core.InlongStreamService;
import org.apache.inlong.manager.workflow.WorkflowContext;
import org.apache.inlong.manager.workflow.event.ListenerResult;
import org.apache.inlong.manager.workflow.event.process.ProcessEvent;
import org.apache.inlong.manager.workflow.event.process.ProcessEventListener;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
-import java.util.List;
-
/**
- * Listener of light group init.
+ * The listener for initial the InlongGroup information.
*/
@Slf4j
@Component
-public class LightGroupInitListener implements ProcessEventListener {
+public class InitGroupListener implements ProcessEventListener {
@Autowired
private InlongGroupService groupService;
- @Autowired
- private InlongStreamService streamService;
-
@Override
public ProcessEvent event() {
return ProcessEvent.CREATE;
}
+ /**
+ * Begin to execute the InlongGroup workflow, init the workflow context, and update other info if needed.
+ */
@Override
- public ListenerResult listen(WorkflowContext context) throws Exception {
- LightGroupResourceProcessForm form = (LightGroupResourceProcessForm) context.getProcessForm();
+ public ListenerResult listen(WorkflowContext context) throws WorkflowListenerException {
+ GroupResourceProcessForm form = (GroupResourceProcessForm) context.getProcessForm();
+ String groupId = form.getInlongGroupId();
+ log.info("begin to execute InitGroupListener for groupId={}", groupId);
+
InlongGroupInfo groupInfo = form.getGroupInfo();
if (groupInfo == null) {
- throw new WorkflowListenerException(ErrorCodeEnum.GROUP_NOT_FOUND.getMessage());
+ throw new BusinessException("inlong group info cannot be null for init group process");
Review Comment:
why here change to `BusinessException` and throws `WorkflowListenerException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] kipshi commented on a diff in pull request #5080: [INLONG-5066][Manager] Remove the LightGroup-related workflow listener and definitions
Posted by GitBox <gi...@apache.org>.
kipshi commented on code in PR #5080:
URL: https://github.com/apache/inlong/pull/5080#discussion_r922949626
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/group/CreateGroupWorkflowDefinition.java:
##########
@@ -41,61 +41,61 @@
public class CreateGroupWorkflowDefinition implements WorkflowDefinition {
@Autowired
- private GroupInitProcessListener groupInitProcessListener;
+ private InitGroupListener initGroupListener;
@Autowired
- private GroupCompleteProcessListener groupCompleteProcessListener;
+ private InitGroupCompleteListener initGroupCompleteListener;
@Autowired
- private GroupFailedProcessListener groupFailedProcessListener;
+ private InitGroupFailedListener initGroupFailedListener;
@Autowired
private GroupTaskListenerFactory groupTaskListenerFactory;
@Override
public WorkflowProcess defineProcess() {
-
// Configuration process
WorkflowProcess process = new WorkflowProcess();
- process.addListener(groupInitProcessListener);
- process.addListener(groupCompleteProcessListener);
- process.addListener(groupFailedProcessListener);
-
- process.setType("Group Resource Creation");
process.setName(getProcessName().name());
+ process.setType(getProcessName().getDisplayName());
process.setDisplayName(getProcessName().getDisplayName());
process.setFormClass(GroupResourceProcessForm.class);
process.setVersion(1);
process.setHidden(1);
+ // Set up the listener
+ process.addListener(initGroupListener);
+ process.addListener(initGroupCompleteListener);
+ process.addListener(initGroupFailedListener);
+
// Start node
StartEvent startEvent = new StartEvent();
process.setStartEvent(startEvent);
- // init MQ
+ // Init MQ
ServiceTask initMQTask = new ServiceTask();
- initMQTask.setName("initMQ");
+ initMQTask.setName("InitMQ");
Review Comment:
make it enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] woofyzhao commented on a diff in pull request #5080: [INLONG-5066][Manager] Remove the LightGroup-related workflow listener and definitions
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on code in PR #5080:
URL: https://github.com/apache/inlong/pull/5080#discussion_r922930978
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/GroupCheckService.java:
##########
@@ -37,30 +35,28 @@
@Service
public class GroupCheckService {
- private static final Logger LOGGER = LoggerFactory.getLogger(GroupCheckService.class);
-
@Autowired
private InlongGroupEntityMapper groupMapper;
/**
* Check whether the inlong group status is temporary
*
- * @param groupId Inlong group id
- * @return Inlong group entity, for caller reuse
+ * @param groupId inlong group id
+ * @return inlong group entity, for caller reuse
*/
public InlongGroupEntity checkGroupStatus(String groupId, String operator) {
InlongGroupEntity inlongGroupEntity = groupMapper.selectByGroupId(groupId);
- Preconditions.checkNotNull(inlongGroupEntity, "groupId is invalid");
+ if (inlongGroupEntity == null) {
+ throw new BusinessException(String.format("InlongGroup does not exist with InlongGroupId=%s", groupId));
+ }
List<String> managers = Arrays.asList(inlongGroupEntity.getInCharges().split(","));
Preconditions.checkTrue(managers.contains(operator),
String.format(ErrorCodeEnum.USER_IS_NOT_MANAGER.getMessage(), operator, managers));
- GroupStatus state = GroupStatus.forCode(inlongGroupEntity.getStatus());
- // Add/modify/delete is not allowed under certain group state
- if (GroupStatus.notAllowedUpdate(state)) {
- LOGGER.error("inlong group status was not allowed to add/update/delete related info");
- throw new BusinessException(ErrorCodeEnum.OPT_NOT_ALLOWED_BY_STATUS);
+ GroupStatus status = GroupStatus.forCode(inlongGroupEntity.getStatus());
+ if (GroupStatus.notAllowedUpdate(status)) {
+ throw new BusinessException(String.format(ErrorCodeEnum.OPT_NOT_ALLOWED_BY_STATUS.getMessage(), status));
Review Comment:
Does the string constant have place holder for status to format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] woofyzhao commented on a diff in pull request #5080: [INLONG-5066][Manager] Remove the LightGroup-related workflow listener and definitions
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on code in PR #5080:
URL: https://github.com/apache/inlong/pull/5080#discussion_r922929820
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/impl/InlongGroupImpl.java:
##########
@@ -129,11 +129,12 @@ public InlongGroupContext init() throws Exception {
}
}
String formDataNew = formDataJson.toString();
- NewGroupProcessForm newGroupProcessForm = JsonUtils.parseObject(
- formDataNew, NewGroupProcessForm.class);
- Preconditions.checkNotNull(newGroupProcessForm, "NewGroupProcessForm cannot be null");
- groupContext.setInitMsg(newGroupProcessForm);
- WorkflowResult startWorkflowResult = workFlowClient.startInlongGroup(taskId, newGroupProcessForm);
+ ApplyGroupProcessForm groupProcessForm = JsonUtils.parseObject(
+ formDataNew, ApplyGroupProcessForm.class);
+ Preconditions.checkNotNull(groupProcessForm, "ApplyGroupProcessForm cannot be null");
+ groupContext.setInitMsg(groupProcessForm);
+ assert groupProcessForm != null;
+ WorkflowResult startWorkflowResult = workFlowClient.startInlongGroup(taskId, groupProcessForm);
Review Comment:
I think it should be "workflowClient"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org