You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Roger Meier (JIRA)" <ji...@apache.org> on 2010/11/03 12:41:47 UTC

[jira] Created: (THRIFT-983) js: add version Info to the library

js: add version Info to the library
-----------------------------------

                 Key: THRIFT-983
                 URL: https://issues.apache.org/jira/browse/THRIFT-983
             Project: Thrift
          Issue Type: Sub-task
          Components: JavaScript - Library
            Reporter: Roger Meier


add version info to the library and update http://wiki.apache.org/thrift/HowToVersion

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (THRIFT-983) js: add version Info to the library

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier reassigned THRIFT-983:
----------------------------------

    Assignee: Roger Meier

> js: add version Info to the library
> -----------------------------------
>
>                 Key: THRIFT-983
>                 URL: https://issues.apache.org/jira/browse/THRIFT-983
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: JavaScript - Library
>            Reporter: Roger Meier
>            Assignee: Roger Meier
>
> add version info to the library and update http://wiki.apache.org/thrift/HowToVersion

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-983) js: add version Info to the library

Posted by "Henrique Mendonca (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003978#comment-13003978 ] 

Henrique Mendonca commented on THRIFT-983:
------------------------------------------

Hi Roger,

Sorry but do you really want all this info in the JS? Would it not be enough to have it in the comments above? so that you can minify it...

+1 for Thrift.Version only (+Comments)

Cheers

> js: add version Info to the library
> -----------------------------------
>
>                 Key: THRIFT-983
>                 URL: https://issues.apache.org/jira/browse/THRIFT-983
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: JavaScript - Library
>            Reporter: Roger Meier
>            Assignee: Roger Meier
>         Attachments: THRIFT-983_Thrift.js_version_info.patch
>
>
> add version info to the library and update http://wiki.apache.org/thrift/HowToVersion

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (THRIFT-983) js: add version Info to the library

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier updated THRIFT-983:
-------------------------------

    Attachment: THRIFT-983_Thrift.js_version_info.patch

patch adds version info to the JavaScript library, usage:
{code}
<script type="text/javascript" charset="utf-8">
//<![CDATA[
alert(Thrift.Version);
alert(Thrift.Description);
alert(Thrift.License);
alert(Thrift.Homepage);
alert(Thrift.BugReports);
alert(Thrift.Maintainer);
//]]>
</script>
{code}

> js: add version Info to the library
> -----------------------------------
>
>                 Key: THRIFT-983
>                 URL: https://issues.apache.org/jira/browse/THRIFT-983
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: JavaScript - Library
>            Reporter: Roger Meier
>            Assignee: Roger Meier
>         Attachments: THRIFT-983_Thrift.js_version_info.patch
>
>
> add version info to the library and update http://wiki.apache.org/thrift/HowToVersion

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Closed: (THRIFT-983) js: add version Info to the library

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier closed THRIFT-983.
------------------------------

    Resolution: Fixed

committed, with little modifications proposed by Henrique

> js: add version Info to the library
> -----------------------------------
>
>                 Key: THRIFT-983
>                 URL: https://issues.apache.org/jira/browse/THRIFT-983
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: JavaScript - Library
>            Reporter: Roger Meier
>            Assignee: Roger Meier
>         Attachments: THRIFT-983_Thrift.js_version_info.patch
>
>
> add version info to the library and update http://wiki.apache.org/thrift/HowToVersion

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira