You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/04/08 00:45:52 UTC
[kudu-CR](branch-1.12.x) columnar serialization: fix optimized GCC build
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15682
Change subject: columnar_serialization: fix optimized GCC build
......................................................................
columnar_serialization: fix optimized GCC build
It seems that GCC with -O1 or higher is less lenient about the pointer
types passed as the first argument to the _mm_gather* intrinsics. This
was causing the Ubuntu 18 release build to fail.
I was able to reproduce the failure and fix on my own Ubuntu 18 box
using a fastdebug build.
Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Reviewed-on: http://gerrit.cloudera.org:8080/15680
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit b386b71b6733bae903f6a051376b49a727e8b3bb)
---
M src/kudu/common/columnar_serialization.cc
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/15682/1
--
To view, visit http://gerrit.cloudera.org:8080/15682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Gerrit-Change-Number: 15682
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.12.x) columnar serialization: fix optimized GCC build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: columnar_serialization: fix optimized GCC build
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Gerrit-Change-Number: 15682
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.12.x) columnar serialization: fix optimized GCC build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15682 )
Change subject: columnar_serialization: fix optimized GCC build
......................................................................
Patch Set 1: Verified+1
unrelated test failure: AutoRebalancerTest.TestHandlingFailedTservers
--
To view, visit http://gerrit.cloudera.org:8080/15682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Gerrit-Change-Number: 15682
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Apr 2020 04:24:09 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) columnar serialization: fix optimized GCC build
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15682 )
Change subject: columnar_serialization: fix optimized GCC build
......................................................................
columnar_serialization: fix optimized GCC build
It seems that GCC with -O1 or higher is less lenient about the pointer
types passed as the first argument to the _mm_gather* intrinsics. This
was causing the Ubuntu 18 release build to fail.
I was able to reproduce the failure and fix on my own Ubuntu 18 box
using a fastdebug build.
Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Reviewed-on: http://gerrit.cloudera.org:8080/15680
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit b386b71b6733bae903f6a051376b49a727e8b3bb)
Reviewed-on: http://gerrit.cloudera.org:8080/15682
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/common/columnar_serialization.cc
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Hao Hao: Looks good to me, approved
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Gerrit-Change-Number: 15682
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.12.x) columnar serialization: fix optimized GCC build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15682 )
Change subject: columnar_serialization: fix optimized GCC build
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Gerrit-Change-Number: 15682
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Apr 2020 04:24:17 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) columnar serialization: fix optimized GCC build
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15682 )
Change subject: columnar_serialization: fix optimized GCC build
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b69470b238dae7a33fdd6b44cb8be57a26501d7
Gerrit-Change-Number: 15682
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Apr 2020 00:47:58 +0000
Gerrit-HasComments: No