You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/14 09:49:59 UTC

[GitHub] [kafka] ocadaruma opened a new pull request #8870: MINOR: Fix timestampDelta type in doc

ocadaruma opened a new pull request #8870:
URL: https://github.com/apache/kafka/pull/8870


   - Type of `timestampDelta` is written as `varint` in the doc, but actually it's `varlong`
     * https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java#L47
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #8870: MINOR: Fix timestampDelta type in doc

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #8870:
URL: https://github.com/apache/kafka/pull/8870#issuecomment-712558055


   @ocadaruma Could you rebase it again? Our Jenkins was on vacation :(


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #8870: MINOR: Fix timestampDelta type in doc

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #8870:
URL: https://github.com/apache/kafka/pull/8870#issuecomment-711166266


   Ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 merged pull request #8870: MINOR: Fix timestampDelta type in doc

Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #8870:
URL: https://github.com/apache/kafka/pull/8870


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #8870: MINOR: Fix timestampDelta type in doc

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #8870:
URL: https://github.com/apache/kafka/pull/8870#issuecomment-711165720


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #8870: MINOR: Fix timestampDelta type in doc

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #8870:
URL: https://github.com/apache/kafka/pull/8870#issuecomment-711166530


   @ocadaruma Could you rebase to trigger QA?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org