You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "Bill (GitHub)" <gi...@apache.org> on 2019/04/01 20:01:06 UTC

[GitHub] [geode] Bill opened pull request #3388: GEODE-6585: clarify subscription-ack-interval

I tried to make this passage in the doc self-consistent. I also tried to clarify the message by eliminating some redundancy.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3388 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] davebarnes97 closed pull request #3388: GEODE-6585: clarify subscription-ack-interval

Posted by "davebarnes97 (GitHub)" <gi...@apache.org>.
[ pull request closed by davebarnes97 ]

[ Full content available at: https://github.com/apache/geode/pull/3388 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on issue #3388: GEODE-6585: clarify subscription-ack-interval

Posted by "Bill (GitHub)" <gi...@apache.org>.
@davebarnes97 or @joeymcallister perhaps one of you could merge this (I cannot).

I think the JDK11 CI failure is ok given that this was a doc change and the failure is in a DUnit test.

[ Full content available at: https://github.com/apache/geode/pull/3388 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on issue #3388: GEODE-6585: clarify subscription-ack-interval

Posted by "Bill (GitHub)" <gi...@apache.org>.
@joeymcallister and @agingade please review

[ Full content available at: https://github.com/apache/geode/pull/3388 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org