[GitHub] [arrow] mapleFU commented on pull request #34096: GH-34086: [C++][Parquet] Fix writing num_rows to data page v2

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on PR #34096:
URL: https://github.com/apache/arrow/pull/34096#issuecomment-1426164685

   Great, can you help me to understand this patch? So, previouslu DATA_PAGE_V2 has bad num_rows in header, if it has:
   
   ```
   Page1: [50 rows] Page2: [50 rows] 
   ```
   
   The header would be:
   
   ```
   Page1: [50 rows] Page2: [100 rows] 
   ```
   
   And `num_buffered_rows_` is within every page. `rows_written_` is equal to sum of `num_buffered_rows_`, though currently they are added together?
   
   Am I right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org