You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Sahil Takiar (Jira)" <ji...@apache.org> on 2020/10/14 20:06:00 UTC

[jira] [Commented] (IMPALA-9856) Enable result spooling by default

    [ https://issues.apache.org/jira/browse/IMPALA-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214243#comment-17214243 ] 

Sahil Takiar commented on IMPALA-9856:
--------------------------------------

I tried to do this, but hit a DCHECK while running exhaustive tests:
{code:java}
Log file created at: 2020/10/13 15:33:06
Running on machine: impala-ec2-centos74-m5-4xlarge-ondemand-012a.vpc.cloudera.com
Log line format: [IWEF]mmdd hh:mm:ss.uuuuuu threadid file:line] msg
F1013 15:33:06.568224 22912 query-state.cc:877] 914777cab6a164b8:dce62b1d00000000] Check failed: is_cancelled_.Load() == 1 (0 vs. 1) {code}
Mindump Stack:
{code}
Operating system: Linux
                  0.0.0 Linux 3.10.0-693.5.2.el7.x86_64 #1 SMP Fri Oct 20 20:32:50 UTC 2017 x86_64
CPU: amd64
     family 6 model 85 stepping 7
     1 CPU

GPU: UNKNOWN

Crash reason:  SIGABRT
Crash address: 0x7d100002913
Process uptime: not available

Thread 410 (crashed)
 0  libc-2.17.so + 0x351f7
    rax = 0x0000000000000000   rdx = 0x0000000000000006
    rcx = 0xffffffffffffffff   rbx = 0x0000000000000004
    rsi = 0x0000000000005980   rdi = 0x0000000000002913
    rbp = 0x00007f53dff7acc0   rsp = 0x00007f53dff7a948
     r8 = 0x0000000000000000    r9 = 0x00007f53dff7a7c0
    r10 = 0x0000000000000008   r11 = 0x0000000000000202
    r12 = 0x00000000076bb400   r13 = 0x0000000000000086
    r14 = 0x00000000076bb404   r15 = 0x00000000076b3a20
    rip = 0x00007f54b87021f7
    Found by: given as instruction pointer in context
 1  impalad!google::LogMessage::Flush() + 0x1eb
    rbp = 0x00007f53dff7ae10   rsp = 0x00007f53dff7acd0
    rip = 0x00000000051fec5b
    Found by: previous frame's frame pointer
 2  impalad!google::LogMessageFatal::~LogMessageFatal() + 0x9
    rbx = 0x0000000000000001   rbp = 0x00007f53dff7ae60
    rsp = 0x00007f53dff7ad70   r12 = 0x000000000d2ad680
    r13 = 0x00007f5458a88690   r14 = 0x000000002074e8a0
    r15 = 0x0000000000000034   rip = 0x0000000005202859
    Found by: call frame info
 3  impalad!impala::QueryState::MonitorFInstances() [query-state.cc : 877 + 0xc]
    rbx = 0x0000000000000001   rbp = 0x00007f53dff7ae60
    rsp = 0x00007f53dff7ad80   r12 = 0x000000000d2ad680
    r13 = 0x00007f5458a88690   r14 = 0x000000002074e8a0
    r15 = 0x0000000000000034   rip = 0x000000000227b5a0
    Found by: call frame info
 4  impalad!impala::QueryExecMgr::ExecuteQueryHelper(impala::QueryState*) [query-exec-mgr.cc : 162 + 0xf]
    rbx = 0x0000000013e76000   rbp = 0x00007f53dff7b6b0
    rsp = 0x00007f53dff7ae70   r12 = 0x000000000d2ad680
    r13 = 0x00007f5458a88690   r14 = 0x000000002074e8a0
    r15 = 0x0000000000000034   rip = 0x000000000226ad41
    Found by: call frame info
 5  impalad!boost::_mfi::mf1<void, impala::QueryExecMgr, impala::QueryState*>::operator()(impala::QueryExecMgr*, impala::QueryState*) const [mem_fn_template.hpp : 165 + 0xc]
    rbx = 0x0000000013e76000   rbp = 0x00007f53dff7b6e0
    rsp = 0x00007f53dff7b6c0   r12 = 0x000000000d2ad680
    r13 = 0x00007f5458a88690   r14 = 0x000000002074e8a0
    r15 = 0x0000000000000034   rip = 0x0000000002273655
    Found by: call frame info
 6  impalad!void boost::_bi::list2<boost::_bi::value<impala::QueryExecMgr*>, boost::_bi::value<impala::QueryState*> >::operator()<boost::_mfi::mf1<void, impala::QueryExecMgr, impala::QueryState*>, boost::_bi::list0>(boost::_bi::type<void>, boost::_mfi::mf1<void, impala::QueryExecMgr, impala::QueryState*>&, boost::_bi::list0&, int) [bind.hpp : 319 + 0x52]
    rbx = 0x0000000013e76000   rbp = 0x00007f53dff7b720
    rsp = 0x00007f53dff7b6f0   r12 = 0x000000000d2ad680
    r13 = 0x00007f5458a88690   r14 = 0x000000002074e8a0
    r15 = 0x0000000000000034   rip = 0x0000000002272f1e
    Found by: call frame info
 7  impalad!boost::_bi::bind_t<void, boost::_mfi::mf1<void, impala::QueryExecMgr, impala::QueryState*>, boost::_bi::list2<boost::_bi::value<impala::QueryExecMgr*>, boost::_bi::value<impala::QueryState*> > >::operator()() [bind.hpp : 1222 + 0x22]
    rbx = 0x0000000000005980   rbp = 0x00007f53dff7b770
    rsp = 0x00007f53dff7b730   r12 = 0x00000000086e72c0
    r13 = 0x00007f5458a88690   r14 = 0x000000002074e8a0
    r15 = 0x0000000000000034   rip = 0x0000000002272525
    Found by: call frame info
 8  impalad!boost::detail::function::void_function_obj_invoker0<boost::_bi::bind_t<void, boost::_mfi::mf1<void, impala::QueryExecMgr, impala::QueryState*>, boost::_bi::list2<boost::_bi::value<impala::QueryExecMgr*>, boost::_bi::value<impala::QueryState*> > >, void>::invoke(boost::detail::function::function_buffer&) [function_template.hpp : 159 + 0xc]
    rbx = 0x0000000000005980   rbp = 0x00007f53dff7b7a0
    rsp = 0x00007f53dff7b780   r12 = 0x00000000086e72c0
    r13 = 0x00007f5458a88690   r14 = 0x000000002074e8a0
    r15 = 0x0000000000000034   rip = 0x000000000227193f
    Found by: call frame info
 9  impalad!boost::function0<void>::operator()() const [function_template.hpp : 770 + 0x1d]
    rbx = 0x0000000000005980   rbp = 0x00007f53dff7b7e0
    rsp = 0x00007f53dff7b7b0   r12 = 0x00000000086e72c0
    r13 = 0x00007f5458a88690   r14 = 0x000000002074e8a0
    r15 = 0x0000000000000034   rip = 0x0000000002137600
    Found by: call frame info
10  impalad!impala::Thread::SuperviseThread(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, boost::function<void ()>, impala::ThreadDebugInfo const*, impala::Promise<long, (impala::PromiseMode)0>*) [thread.cc : 360 + 0xf]
    rbx = 0x0000000000005980   rbp = 0x00007f53dff7bb70
    rsp = 0x00007f53dff7b7f0   r12 = 0x00000000086e72c0
    r13 = 0x00007f5458a88690   r14 = 0x000000002074e8a0
    r15 = 0x0000000000000034   rip = 0x0000000002715cf2
    Found by: call frame info
11  impalad!void boost::_bi::list5<boost::_bi::value<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, boost::_bi::value<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, boost::_bi::value<boost::function<void ()> >, boost::_bi::value<impala::ThreadDebugInfo*>, boost::_bi::value<impala::Promise<long, (impala::PromiseMode)0>*> >::operator()<void (*)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, boost::function<void ()>, impala::ThreadDebugInfo const*, impala::Promise<long, (impala::PromiseMode)0>*), boost::_bi::list0>(boost::_bi::type<void>, void (*&)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, boost::function<void ()>, impala::ThreadDebugInfo const*, impala::Promise<long, (impala::PromiseMode)0>*), boost::_bi::list0&, int) [bind.hpp : 531 + 0x15]
    rbx = 0x00000000027159ac   rbp = 0x00007f53dff7bbe0
    rsp = 0x00007f53dff7bb80   r12 = 0x00007f5458a89840
    r13 = 0x00007f5458a88690   r14 = 0x000000002074e8a0
    r15 = 0x0000000000000034   rip = 0x000000000271dc8f
    Found by: call frame info
12  impalad!boost::_bi::bind_t<void, void (*)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, boost::function<void ()>, impala::ThreadDebugInfo const*, impala::Promise<long, (impala::PromiseMode)0>*), boost::_bi::list5<boost::_bi::value<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, boost::_bi::value<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, boost::_bi::value<boost::function<void ()> >, boost::_bi::value<impala::ThreadDebugInfo*>, boost::_bi::value<impala::Promise<long, (impala::PromiseMode)0>*> > >::operator()() [bind.hpp : 1222 + 0x22]
    rbx = 0x000000002074e6c0   rbp = 0x00007f53dff7bc30
    rsp = 0x00007f53dff7bbf0   r12 = 0x0000000000000000
    r13 = 0x00007f53dff7c9c0   r14 = 0x00007f53dff7c700
    r15 = 0x0000000000000034   rip = 0x000000000271dbb3
    Found by: call frame info
13  impalad!boost::detail::thread_data<boost::_bi::bind_t<void, void (*)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, boost::function<void ()>, impala::ThreadDebugInfo const*, impala::Promise<long, (impala::PromiseMode)0>*), boost::_bi::list5<boost::_bi::value<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, boost::_bi::value<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, boost::_bi::value<boost::function<void ()> >, boost::_bi::value<impala::ThreadDebugInfo*>, boost::_bi::value<impala::Promise<long, (impala::PromiseMode)0>*> > > >::run() [thread.hpp : 116 + 0x12]
    rbx = 0x000000002074e6c0   rbp = 0x00007f53dff7bc50
    rsp = 0x00007f53dff7bc40   r12 = 0x0000000000000000
    r13 = 0x00007f53dff7c9c0   r14 = 0x00007f53dff7c700
    r15 = 0x0000000000000034   rip = 0x000000000271db74
    Found by: call frame info
{code}

Probably not going to work on this anytime soon, but whoever picks this up should confirm this DCHECK is resolved.

> Enable result spooling by default
> ---------------------------------
>
>                 Key: IMPALA-9856
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9856
>             Project: IMPALA
>          Issue Type: Task
>          Components: Backend
>            Reporter: Sahil Takiar
>            Priority: Major
>
> Result spooling has been relatively stable since it was introduced, and it has several benefits described inĀ IMPALA-8656. It would be good to enable it by default.
> I looked into doing this a while ago, and there are a bunch of tests that rely on the "fetch one row batch at a time" behavior. Those tests fail when result spooling is enabled.
> The remaining linked tasks inĀ IMPALA-8656 should be completed as well before enabling result spooling by default.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org