[jira] [Commented] (NIFI-305) Refactor base class from MergeContent

["Joseph Witt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292701#comment-14292701 ] 

Joseph Witt commented on NIFI-305:
----------------------------------

Totally agree.  This processor inspired many chats on design patterns like 'strategy' which we wanted to make a first class function.  We ended up where you suggest which is deciding refactoring such classes into libs is better for now.

> Refactor base class from MergeContent
> -------------------------------------
>
>                 Key: NIFI-305
>                 URL: https://issues.apache.org/jira/browse/NIFI-305
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 0.0.1
>            Reporter: Joseph Gresock
>            Priority: Minor
>
> The binning logic in MergeContent is extremely useful, and could be pulled out into an abstract superclass.  This would allow other processors to perform binning logic without being tied to a merged flow file.  For example, a processor may want to submit a batch request to a database like Solr, or to a REST endpoint.  
> The vast majority of the code in MergeContent would remain in the concrete class, but there are several points, such as the BinManager usage, that could be abstracted for easy extensibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)