You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Gerolf Seitz <ge...@gmail.com> on 2008/04/01 22:26:01 UTC

Re: [jira] Created: (WICKET-1469) New Wicket tag 'wicket:for'

what do you guys think about this?
i talked to Jan about this and i think this could really remove
some boilerplate code.

I have implemented it based on WicketMessageTagHandler.
the wicket:for attribute is only processed on label tags.
"wicket:message" in the example would have to be something different,
because
it conflicts with WicketMessageTagHandler. i suggest "wicket:label" (or
whatever
would be the best name for that).

any thoughts?

  Gerolf

On Tue, Apr 1, 2008 at 2:32 PM, Jan Kriesten (JIRA) <ji...@apache.org> wrote:

> New Wicket tag 'wicket:for'
> ---------------------------
>
>                 Key: WICKET-1469
>                 URL: https://issues.apache.org/jira/browse/WICKET-1469
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.3.2
>            Reporter: Jan Kriesten
>            Priority: Minor
>
>
> This often happens during my daily work:
>
> You create a form with labels and corresponding input fields. As it is
> now, you have to bind all those Labels and FormComponents together with some
> "boilerplate" code within Java.
>
> I'd like to suggest the following enhancement Wicket tag:
>
> <label wicket:for="username" wicket:messge="key">default message</label>
>
> where wicket:for contains the referenced wicket:id
>
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Re: [jira] Created: (WICKET-1469) New Wicket tag 'wicket:for'

Posted by Igor Vaynberg <ig...@gmail.com>.
i dont think i would want to support something that is
markup-placement-specific. we have formcomponentlabel that does this
and it works in all situations. dont know, this is my opinion, others
may have different ones.

-igor

On Tue, Apr 1, 2008 at 4:32 PM, Gerolf Seitz <ge...@gmail.com> wrote:
> yeah, that would take away the convenience it's made for and
>  would probably result in some more emails on users@...
>
>  if that's a blocker, i'm okay with that.
>
>   Gerolf
>
>  On Tue, Apr 1, 2008 at 10:56 PM, Igor Vaynberg <ig...@gmail.com>
>  wrote:
>
>
>
>  > if that is in markup _after_ the component and component doesnt have
>  > setoutputmarkupid(true) what happens?
>  >
>  > -igor
>  >
>  >
>  > On Tue, Apr 1, 2008 at 1:26 PM, Gerolf Seitz <ge...@gmail.com>
>  > wrote:
>  > > what do you guys think about this?
>  > >  i talked to Jan about this and i think this could really remove
>  > >  some boilerplate code.
>  > >
>  > >  I have implemented it based on WicketMessageTagHandler.
>  > >  the wicket:for attribute is only processed on label tags.
>  > >  "wicket:message" in the example would have to be something different,
>  > >  because
>  > >  it conflicts with WicketMessageTagHandler. i suggest "wicket:label" (or
>  > >  whatever
>  > >  would be the best name for that).
>  > >
>  > >  any thoughts?
>  > >
>  > >   Gerolf
>  > >
>  > >  On Tue, Apr 1, 2008 at 2:32 PM, Jan Kriesten (JIRA) <ji...@apache.org>
>  > wrote:
>  > >
>  > >  > New Wicket tag 'wicket:for'
>  > >  > ---------------------------
>  > >  >
>  > >  >                 Key: WICKET-1469
>  > >  >                 URL:
>  > https://issues.apache.org/jira/browse/WICKET-1469
>  > >  >             Project: Wicket
>  > >  >          Issue Type: New Feature
>  > >  >          Components: wicket
>  > >  >    Affects Versions: 1.3.2
>  > >  >            Reporter: Jan Kriesten
>  > >  >            Priority: Minor
>  > >  >
>  > >  >
>  > >  > This often happens during my daily work:
>  > >  >
>  > >  > You create a form with labels and corresponding input fields. As it
>  > is
>  > >  > now, you have to bind all those Labels and FormComponents together
>  > with some
>  > >  > "boilerplate" code within Java.
>  > >  >
>  > >  > I'd like to suggest the following enhancement Wicket tag:
>  > >  >
>  > >  > <label wicket:for="username" wicket:messge="key">default
>  > message</label>
>  > >  >
>  > >  > where wicket:for contains the referenced wicket:id
>  > >  >
>  > >  >
>  > >  > --
>  > >  > This message is automatically generated by JIRA.
>  > >  > -
>  > >  > You can reply to this email to add a comment to the issue online.
>  > >  >
>  > >  >
>  > >
>  >
>

Re: [jira] Created: (WICKET-1469) New Wicket tag 'wicket:for'

Posted by Gerolf Seitz <ge...@gmail.com>.
yeah, that would take away the convenience it's made for and
would probably result in some more emails on users@...

if that's a blocker, i'm okay with that.

  Gerolf

On Tue, Apr 1, 2008 at 10:56 PM, Igor Vaynberg <ig...@gmail.com>
wrote:

> if that is in markup _after_ the component and component doesnt have
> setoutputmarkupid(true) what happens?
>
> -igor
>
>
> On Tue, Apr 1, 2008 at 1:26 PM, Gerolf Seitz <ge...@gmail.com>
> wrote:
> > what do you guys think about this?
> >  i talked to Jan about this and i think this could really remove
> >  some boilerplate code.
> >
> >  I have implemented it based on WicketMessageTagHandler.
> >  the wicket:for attribute is only processed on label tags.
> >  "wicket:message" in the example would have to be something different,
> >  because
> >  it conflicts with WicketMessageTagHandler. i suggest "wicket:label" (or
> >  whatever
> >  would be the best name for that).
> >
> >  any thoughts?
> >
> >   Gerolf
> >
> >  On Tue, Apr 1, 2008 at 2:32 PM, Jan Kriesten (JIRA) <ji...@apache.org>
> wrote:
> >
> >  > New Wicket tag 'wicket:for'
> >  > ---------------------------
> >  >
> >  >                 Key: WICKET-1469
> >  >                 URL:
> https://issues.apache.org/jira/browse/WICKET-1469
> >  >             Project: Wicket
> >  >          Issue Type: New Feature
> >  >          Components: wicket
> >  >    Affects Versions: 1.3.2
> >  >            Reporter: Jan Kriesten
> >  >            Priority: Minor
> >  >
> >  >
> >  > This often happens during my daily work:
> >  >
> >  > You create a form with labels and corresponding input fields. As it
> is
> >  > now, you have to bind all those Labels and FormComponents together
> with some
> >  > "boilerplate" code within Java.
> >  >
> >  > I'd like to suggest the following enhancement Wicket tag:
> >  >
> >  > <label wicket:for="username" wicket:messge="key">default
> message</label>
> >  >
> >  > where wicket:for contains the referenced wicket:id
> >  >
> >  >
> >  > --
> >  > This message is automatically generated by JIRA.
> >  > -
> >  > You can reply to this email to add a comment to the issue online.
> >  >
> >  >
> >
>

Re: [jira] Created: (WICKET-1469) New Wicket tag 'wicket:for'

Posted by Igor Vaynberg <ig...@gmail.com>.
if that is in markup _after_ the component and component doesnt have
setoutputmarkupid(true) what happens?

-igor


On Tue, Apr 1, 2008 at 1:26 PM, Gerolf Seitz <ge...@gmail.com> wrote:
> what do you guys think about this?
>  i talked to Jan about this and i think this could really remove
>  some boilerplate code.
>
>  I have implemented it based on WicketMessageTagHandler.
>  the wicket:for attribute is only processed on label tags.
>  "wicket:message" in the example would have to be something different,
>  because
>  it conflicts with WicketMessageTagHandler. i suggest "wicket:label" (or
>  whatever
>  would be the best name for that).
>
>  any thoughts?
>
>   Gerolf
>
>  On Tue, Apr 1, 2008 at 2:32 PM, Jan Kriesten (JIRA) <ji...@apache.org> wrote:
>
>  > New Wicket tag 'wicket:for'
>  > ---------------------------
>  >
>  >                 Key: WICKET-1469
>  >                 URL: https://issues.apache.org/jira/browse/WICKET-1469
>  >             Project: Wicket
>  >          Issue Type: New Feature
>  >          Components: wicket
>  >    Affects Versions: 1.3.2
>  >            Reporter: Jan Kriesten
>  >            Priority: Minor
>  >
>  >
>  > This often happens during my daily work:
>  >
>  > You create a form with labels and corresponding input fields. As it is
>  > now, you have to bind all those Labels and FormComponents together with some
>  > "boilerplate" code within Java.
>  >
>  > I'd like to suggest the following enhancement Wicket tag:
>  >
>  > <label wicket:for="username" wicket:messge="key">default message</label>
>  >
>  > where wicket:for contains the referenced wicket:id
>  >
>  >
>  > --
>  > This message is automatically generated by JIRA.
>  > -
>  > You can reply to this email to add a comment to the issue online.
>  >
>  >
>