You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/10/26 15:42:20 UTC
[GitHub] [mynewt-newt] agross-korg commented on a change in pull request #418: Add Section TLV support to images
agross-korg commented on a change in pull request #418:
URL: https://github.com/apache/mynewt-newt/pull/418#discussion_r512061293
##########
File path: newt/imgprod/imgprod.go
##########
@@ -312,10 +318,55 @@ func OptsFromTgtBldr(b *builder.TargetBuilder, ver image.ImageVersion,
func ProduceAll(t *builder.TargetBuilder, ver image.ImageVersion,
sigKeys []sec.PrivSignKey, encKeyFilename string, encKeyIndex int,
- hdrPad int, imagePad int) error {
+ hdrPad int, imagePad int, sectionString string) error {
+
+ elfPath := t.AppBuilder.AppElfPath()
+
+ cmdName := "arm-none-eabi-objdump"
Review comment:
yeah good point. I'll have to put that on the future todo list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org