[jira] [Comment Edited] (CALCITE-4917) Add test for 'a IS NOT NULL AND a = b' simplification

["Alessandro Solimando (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452572#comment-17452572 ] 

Alessandro Solimando edited comment on CALCITE-4917 at 12/2/21, 7:37 PM:
-------------------------------------------------------------------------

Thanks Julian for your suggestions.

At first I wanted to add the case to "testSimplifyAndIsNotNull", but the test's focus is on a specific Jira ticket (as per its Javadoc), so I was afraid it might be confusing to add it there, and I finally went for a separate test.

Do you think this would be a problem or is it OK if I merge the two tests in "testSimplifyAndIsNotNull" (with a comment along the line of the one you cited)?


was (Author: asolimando):
Thanks Julian for your suggestions.

At first I wanted to add the case to "testSimplifyAndIsNotNull", but the test's focus is based on a specific Jira ticket (as per its Javadoc), so I was afraid it might be confusing to add it there, and I finally went for a separate test.

Do you think this would be a problem or is it OK if I merge the two tests in "testSimplifyAndIsNotNull" (with a comment along the line of the one you cited)?

> Add test for 'a IS NOT NULL AND a = b' simplification
> -----------------------------------------------------
>
>                 Key: CALCITE-4917
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4917
>             Project: Calcite
>          Issue Type: Test
>          Components: core
>    Affects Versions: 1.28.0
>            Reporter: Alessandro Solimando
>            Assignee: Alessandro Solimando
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Simplification (from _RexSimplify_ class) is mostly covered in {_}RexProgramTest{_}, but tests for expressions of the form "IS NOT NULL(a) AND a=b" (with nullable and not nullable types) seem to be missing.
>  
> Since I had to write tests to make sure the simplification was as expected, I assume others might end up doing the same, and that the tests will both act as documentation and it will also protect against regressions.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)