You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/16 06:26:18 UTC
[GitHub] [spark] Ngone51 opened a new pull request #27923:
[SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle
non-existed path
Ngone51 opened a new pull request #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Wrap try-catch on `fs.getFileStatus(path)` within acl/permission in case of the path doesn't exist.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
`truncate table` may fail to re-create path in case of interruption or something else. As a result, next time we `truncate table` on the same table with acl/permission, it will fail due to `FileNotFoundException`. And it also brings behavior change compares to previous Spark version, which could still `truncate table` successfully even if the path doesn't exist.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #27923: [SPARK-31163][SQL]
TruncateTableCommand with acl/permission should handle non-existed path
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599835848
thanks all!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27923: [SPARK-31163][SQL]
TruncateTableCommand with acl/permission should handle non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599368004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24567/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27923:
[SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle
non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599376285
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27923:
[SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle
non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599523574
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119849/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27923:
[SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle
non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599387272
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27923: [SPARK-31163][SQL]
TruncateTableCommand with acl/permission should handle non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599376291
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119836/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27923: [SPARK-31163][SQL]
TruncateTableCommand with acl/permission should handle non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599523564
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27923:
[SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle
non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599387280
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24576/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27923: [SPARK-31163][SQL]
TruncateTableCommand with acl/permission should handle non-existed path
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599376252
**[Test build #119836 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119836/testReport)** for PR 27923 at commit [`cd84627`](https://github.com/apache/spark/commit/cd846270a2307ae07c3abecd0b476f678cb010bf).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27923: [SPARK-31163][SQL]
TruncateTableCommand with acl/permission should handle non-existed path
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599386933
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27923: [SPARK-31163][SQL]
TruncateTableCommand with acl/permission should handle non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599387272
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27923:
[SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle
non-existed path
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599389493
**[Test build #119849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119849/testReport)** for PR 27923 at commit [`cd84627`](https://github.com/apache/spark/commit/cd846270a2307ae07c3abecd0b476f678cb010bf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 edited a comment on issue #27923:
[SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle
non-existed path
Posted by GitBox <gi...@apache.org>.
Ngone51 edited a comment on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599366673
cc @viirya @cloud-fan @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27923: [SPARK-31163][SQL]
TruncateTableCommand with acl/permission should handle non-existed path
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599389493
**[Test build #119849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119849/testReport)** for PR 27923 at commit [`cd84627`](https://github.com/apache/spark/commit/cd846270a2307ae07c3abecd0b476f678cb010bf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27923:
[SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle
non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599367995
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27923:
[SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle
non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599376291
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119836/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27923:
[SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle
non-existed path
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599367687
**[Test build #119836 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119836/testReport)** for PR 27923 at commit [`cd84627`](https://github.com/apache/spark/commit/cd846270a2307ae07c3abecd0b476f678cb010bf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27923:
[SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle
non-existed path
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27923:
[SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle
non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599368004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24567/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #27923: [SPARK-31163][SQL]
TruncateTableCommand with acl/permission should handle non-existed path
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599366673
@ cc @viirya @cloud-fan @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27923: [SPARK-31163][SQL]
TruncateTableCommand with acl/permission should handle non-existed path
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599522497
**[Test build #119849 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119849/testReport)** for PR 27923 at commit [`cd84627`](https://github.com/apache/spark/commit/cd846270a2307ae07c3abecd0b476f678cb010bf).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27923:
[SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle
non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599523564
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27923: [SPARK-31163][SQL]
TruncateTableCommand with acl/permission should handle non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599376285
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27923:
[SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle
non-existed path
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#discussion_r392821202
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
##########
@@ -2084,6 +2084,27 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
}
}
+ test("SPARK-31163: acl/permission should handle non-existed path when truncating table") {
+ withSQLConf(SQLConf.TRUNCATE_TABLE_IGNORE_PERMISSION_ACL.key -> "false") {
+ withTable("tab1") {
+ sql("CREATE TABLE tab1 (col1 STRING, col2 INT) USING parquet PARTITIONED BY (col2)")
+ sql("INSERT INTO tab1 SELECT 'one', 1")
+ checkAnswer(spark.table("tab1"), Row("one", 1))
+ val part = spark.sessionState.catalog.listPartitions(TableIdentifier("tab1")).head
+ val path = new File(part.location.getPath)
+ sql("TRUNCATE TABLE tab1")
+ // simulate incomplete/unsuccessful truncate
+ assert(path.exists())
+ path.delete()
+ assert(!path.exists())
+ // execute without java.io.FileNotFoundException
+ sql("TRUNCATE TABLE tab1")
+ // partition path should be re-created
Review comment:
this only affects partition path, or table path as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27923: [SPARK-31163][SQL]
TruncateTableCommand with acl/permission should handle non-existed path
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599367687
**[Test build #119836 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119836/testReport)** for PR 27923 at commit [`cd84627`](https://github.com/apache/spark/commit/cd846270a2307ae07c3abecd0b476f678cb010bf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27923: [SPARK-31163][SQL]
TruncateTableCommand with acl/permission should handle non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599523574
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119849/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27923: [SPARK-31163][SQL]
TruncateTableCommand with acl/permission should handle non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599387280
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24576/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #27923:
[SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle
non-existed path
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#discussion_r392827342
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
##########
@@ -2084,6 +2084,27 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
}
}
+ test("SPARK-31163: acl/permission should handle non-existed path when truncating table") {
+ withSQLConf(SQLConf.TRUNCATE_TABLE_IGNORE_PERMISSION_ACL.key -> "false") {
+ withTable("tab1") {
+ sql("CREATE TABLE tab1 (col1 STRING, col2 INT) USING parquet PARTITIONED BY (col2)")
+ sql("INSERT INTO tab1 SELECT 'one', 1")
+ checkAnswer(spark.table("tab1"), Row("one", 1))
+ val part = spark.sessionState.catalog.listPartitions(TableIdentifier("tab1")).head
+ val path = new File(part.location.getPath)
+ sql("TRUNCATE TABLE tab1")
+ // simulate incomplete/unsuccessful truncate
+ assert(path.exists())
+ path.delete()
+ assert(!path.exists())
+ // execute without java.io.FileNotFoundException
+ sql("TRUNCATE TABLE tab1")
+ // partition path should be re-created
Review comment:
Both, but can be more likely to happen on partition path since there's much more than table path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27923: [SPARK-31163][SQL]
TruncateTableCommand with acl/permission should handle non-existed path
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27923: [SPARK-31163][SQL] TruncateTableCommand with acl/permission should handle non-existed path
URL: https://github.com/apache/spark/pull/27923#issuecomment-599367995
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org