You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/04/21 14:50:14 UTC

Re: [PR] feat: make FFI structs fields pub. [arrow-rs]

alamb commented on code in PR #9772:
URL: https://github.com/apache/arrow-rs/pull/9772#discussion_r3118290912


##########
arrow-array/src/ffi_stream.rs:
##########
@@ -100,6 +100,7 @@ pub struct FFI_ArrowArrayStream {
 }
 
 unsafe impl Send for FFI_ArrowArrayStream {}
+unsafe impl Sync for FFI_ArrowArrayStream {}

Review Comment:
   Why is this change made? I didn't see any mention of it in the PR description and given there are a buch of pointers involved I am not sure if it is safe to share this data across threads 🤔 



##########
arrow-schema/src/ffi.rs:
##########
@@ -409,6 +418,7 @@ impl Drop for FFI_ArrowSchema {
 }
 
 unsafe impl Send for FFI_ArrowSchema {}
+unsafe impl Sync for FFI_ArrowSchema {}

Review Comment:
   likewise here -- why is this necessary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org