You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by rh...@apache.org on 2010/04/13 20:28:34 UTC

svn commit: r933734 - in /qpid/trunk/qpid/python/qpid: messaging/driver.py tests/messaging/endpoints.py

Author: rhs
Date: Tue Apr 13 18:28:34 2010
New Revision: 933734

URL: http://svn.apache.org/viewvc?rev=933734&view=rev
Log:
fixed a hang in commit and added testDoubleCommit

Modified:
    qpid/trunk/qpid/python/qpid/messaging/driver.py
    qpid/trunk/qpid/python/qpid/tests/messaging/endpoints.py

Modified: qpid/trunk/qpid/python/qpid/messaging/driver.py
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/python/qpid/messaging/driver.py?rev=933734&r1=933733&r2=933734&view=diff
==============================================================================
--- qpid/trunk/qpid/python/qpid/messaging/driver.py (original)
+++ qpid/trunk/qpid/python/qpid/messaging/driver.py Tue Apr 13 18:28:34 2010
@@ -1020,6 +1020,7 @@ class Engine:
         ssn.committed = True
         ssn.aborting = False
         ssn.aborted = False
+        sst.committing = False
       sst.write_cmd(TxCommit(), commit_ok)
       sst.committing = True
 

Modified: qpid/trunk/qpid/python/qpid/tests/messaging/endpoints.py
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/python/qpid/tests/messaging/endpoints.py?rev=933734&r1=933733&r2=933734&view=diff
==============================================================================
--- qpid/trunk/qpid/python/qpid/tests/messaging/endpoints.py (original)
+++ qpid/trunk/qpid/python/qpid/tests/messaging/endpoints.py Tue Apr 13 18:28:34 2010
@@ -483,6 +483,18 @@ class SessionTests(Base):
   def testRollbackAck(self):
     self.txTestAck(False)
 
+  def testDoubleCommit(self):
+    ssn = self.conn.session(transactional=True)
+    snd = ssn.sender("amq.direct")
+    rcv = ssn.receiver("amq.direct")
+    msgs = [self.message("testDoubleCommit", i) for i in range(3)]
+    for m in msgs:
+      snd.send(m)
+    ssn.commit()
+    self.drain(rcv, expected=msgs)
+    ssn.acknowledge()
+    ssn.commit()
+
   def testClose(self):
     self.ssn.close()
     try:



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org