You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2024/03/21 09:17:55 UTC
[PR] [SPARK-47500][PYTHON][CONNECT] Factor column name handling out of `plan.py` [spark]
zhengruifeng opened a new pull request, #45636:
URL: https://github.com/apache/spark/pull/45636
### What changes were proposed in this pull request?
Factor column name handling out of `plan.py`
### Why are the changes needed?
we have too many parameters preprocessing in `plan.py`, e.g. the column name handling,
we introduced multiple duplicated helper functions here and there, make it hard to following some times.
### Does this PR introduce _any_ user-facing change?
no, just code refactor
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47500][PYTHON][CONNECT] Factor column name handling out of `plan.py` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #45636: [SPARK-47500][PYTHON][CONNECT] Factor column name handling out of `plan.py`
URL: https://github.com/apache/spark/pull/45636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47500][PYTHON][CONNECT] Factor column name handling out of `plan.py` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #45636:
URL: https://github.com/apache/spark/pull/45636#issuecomment-2014422902
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org