You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by fversaci <gi...@git.apache.org> on 2015/11/25 12:28:04 UTC

[GitHub] flink pull request: typo in DelimitedInputFormat

GitHub user fversaci opened a pull request:

    https://github.com/apache/flink/pull/1405

    typo in DelimitedInputFormat

    in both DelimitedInputFormat.java and DelimitedInputFormatSamplingTest.java it's written loadGloablConfigParams insted of loadGlobalConfigParams, is it safe to correct it?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fversaci/flink patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1405.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1405
    
----
commit c3751fd6758f56ac7d0b01f3d0e56c8a997ad2fd
Author: fversaci <fr...@gmail.com>
Date:   2015-11-25T11:12:50Z

    Update DelimitedInputFormat.java
    
    typo in function name

commit e38d2d7e6793d3eaf9ea511bede669849ff8fb09
Author: fversaci <fr...@gmail.com>
Date:   2015-11-25T11:14:23Z

    Update DelimitedInputFormatSamplingTest.java
    
    typo in function name (also present in flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java)

commit 5a7f8daaada7bb54a68835c5c9d2f66a16982fcb
Author: fversaci <fr...@gmail.com>
Date:   2015-11-25T11:21:34Z

    Merge pull request #1 from fversaci/patch-2
    
    Update DelimitedInputFormatSamplingTest.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: typo in DelimitedInputFormat

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1405#issuecomment-159747580
  
    Will merge this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: typo in DelimitedInputFormat

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1405


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: typo in DelimitedInputFormat

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1405#issuecomment-159588623
  
    Good catch, +1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---