[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1459: MINIFICPP-1987 Configuring processor metrics with regular expressions

[GitBox <gi...@apache.org>]

lordgamez commented on code in PR #1459:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1459#discussion_r1031695415


##########
C2.md:
##########
@@ -117,6 +117,10 @@ a configuration of an agent
     nifi.c2.root.class.definitions.metrics.metrics.processorMetrics.name=ProcessorMetric
     nifi.c2.root.class.definitions.metrics.metrics.processorMetrics.classes=GetFileMetrics
 
+Processor metrics can also be configured using regular expressions with the `processorMetrics/` prefix, so the following definition is also valid:

Review Comment:
   The reason I went with this instead is because we are filtering metrics not processors, so one would think that the `processors/` prefix means we have to specify `processors/TailFile` or `processors/GetFile` for example. In fact those would not match any processor metrics, because we use regex match instead of regex search in the implementation.
   
   The other reason is that in this example it is obvious that we are referring to metrics, but in this context `nifi.c2.root.class.definitions.metrics` is an arbitrary user defined class, so the class may not contain the `metrics` in the class definition. In case the metrics are defined in an another C2 node like `nifi.c2.root.class.definitions.mynodes` class for example or requested in the `nifi.c2.root.classes` it may not be so obvious we want to filter for metrics. C2 can support any response node that may or may not be metric nodes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org