[jira] [Created] (HIVE-8837) Improvement in the comment and code in the trim() method of org.apache.hadoop.hive.ql.udf.generic.NumericHistogram

["Jie Liu (JIRA)" <ji...@apache.org>]

Jie Liu created HIVE-8837:
-----------------------------

             Summary: Improvement in the comment and code in the trim() method of org.apache.hadoop.hive.ql.udf.generic.NumericHistogram
                 Key: HIVE-8837
                 URL: https://issues.apache.org/jira/browse/HIVE-8837
             Project: Hive
          Issue Type: Wish
            Reporter: Jie Liu
            Priority: Minor


According to the comment: https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NumericHistogram.java#L243-L244, the new bins[smallestdiffloc] may be calculated by x = y1 / d * x1 + y2 / d * x2, but the comments and code below seems to use x = y1 / d * x1 + x2 / d * y2.

The result should be the same, but it confuses me. I am trying to implement similar things.

Thanks,
Jie



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)