[jira] [Commented] (HBASE-11354) HConnectionImplementation#DelayedClosing does not start

["Qianxi Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031810#comment-14031810 ] 

Qianxi Zhang commented on HBASE-11354:
--------------------------------------

I want to know why we need DelayedClosing. I can not find the issue about it. I modify the method "createAndStart" to create the instance and start the thread, but I find that the client exit will be more slowly. I think the reason is that the thread sleeps for a while. Could we interrupt the thread when the connection is closed ? 

> HConnectionImplementation#DelayedClosing does not start
> -------------------------------------------------------
>
>                 Key: HBASE-11354
>                 URL: https://issues.apache.org/jira/browse/HBASE-11354
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.99.0, 0.98.3
>            Reporter: Qianxi Zhang
>            Assignee: Qianxi Zhang
>
> The method "createAndStart" in class DelayedClosing only creates a instance, but forgets to start it. So thread delayedClosing is not running all the time.
> ConnectionManager#1623
> {code}
>       static DelayedClosing createAndStart(HConnectionImplementation hci){
>         Stoppable stoppable = new Stoppable() {
>               private volatile boolean isStopped = false;
>               @Override public void stop(String why) { isStopped = true;}
>               @Override public boolean isStopped() {return isStopped;}
>             };
>         return new DelayedClosing(hci, stoppable);
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)