You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/08 15:55:05 UTC

[GitHub] [arrow] wesm commented on a change in pull request #8136: ARROW-9078: [C++] Parquet read / write extension type with nested storage type

wesm commented on a change in pull request #8136:
URL: https://github.com/apache/arrow/pull/8136#discussion_r485027960



##########
File path: cpp/src/arrow/extension_type.h
##########
@@ -80,6 +81,12 @@ class ARROW_EXPORT ExtensionType : public DataType {
   /// \return the serialized representation
   virtual std::string Serialize() const = 0;
 
+  static std::shared_ptr<Array> WrapArray(const std::shared_ptr<DataType>& ext_type,
+                                          const std::shared_ptr<Array>& storage);
+  static std::shared_ptr<ChunkedArray> WrapArray(
+      const std::shared_ptr<DataType>& ext_type,
+      const std::shared_ptr<ChunkedArray>& storage);

Review comment:
       Seems OK to me. May want doxygen comments




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org