You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/23 09:45:03 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #17187: Do not seek error file when it is closed

uranusjr commented on a change in pull request #17187:
URL: https://github.com/apache/airflow/pull/17187#discussion_r675437369



##########
File path: tests/models/test_taskinstance.py
##########
@@ -119,6 +125,18 @@ def setUp(self):
     def tearDown(self):
         self.clean_db()
 
+    def test_load_error_file_returns_None_for_closed_file(self):
+        error_fd = create_tempfile()

Review comment:
       It’s probably easier (and slightly more efficient) to do `io.TextIO()` instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org