[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6613: libc/stdio: Support "long long" type if CONFIG_HAVE_LONG_LONG is enabled

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on PR #6613:
URL: https://github.com/apache/incubator-nuttx/pull/6613#issuecomment-1185102582

   > > The current PR reduces code size by disabling long long support for printf (I will double check scanf) and still keeps support of `%ll` and `%ull` by mapping those to `%l` and `%ul`. I think that it addresses the size increase concern raised in the previous PR. @acassis I'm not sure if the Kconfig example that you mentioned will work since HAVE_LONG_LONG is not a Kconfig option (at least for now)
   > 
   > Good point! My fault, in fact CONFIG_HAVE_LONG_LONG is defined by the header file. So, maybe we can get rid of CONFIG_LIBC_HAVE_LONG_LONG and only use CONFIG_HAVE_LONG_LONG, because if the system doesn't have it, it will fallback to LONG.
   
   Once we move CONFIG_HAVE_LONG_LONG to Kconfig, we can apply @acassis 's suggestion to simplify the default setting. Look like @ALTracer will provide a patch for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org