[jira] [Updated] (SLIDER-874) Some RAT cleanup

["Josh Elser (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLIDER-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Josh Elser updated SLIDER-874:
------------------------------
    Attachment: 0001-SLIDER-874-Restructure-modules-pom.xml-for-better-co.patch

A series of changes that aim to make RAT exclusions more targeted per-module. This required some movement of files (notably, src/test/clusters) around to reduce the repeated exclusions. Reordering files also helps ensure RAT's default maven+intellij+eclipse exclusions work as intended.

The biggest problem with the previous approach is that the exclusions seemed to think they were inherited from the parent module. The fact of the matter is that providing new configuration to the rat-plugin will override the parent module's configuration.

Wanted to get some feedback before directly applying. Tested myself using {{mvn apache-rat:check -Pall-modules,all-packages,rat}}.

> Some RAT cleanup
> ----------------
>
>                 Key: SLIDER-874
>                 URL: https://issues.apache.org/jira/browse/SLIDER-874
>             Project: Slider
>          Issue Type: Improvement
>    Affects Versions: Slider 0.80
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Minor
>             Fix For: Slider 0.81
>
>         Attachments: 0001-SLIDER-874-Restructure-modules-pom.xml-for-better-co.patch
>
>
> Noticed auditing slider-0.80, a few things we can clean up:
> * Eclipse project files aren't ignored
> * Some files in target/ were not ignored
> * All of app-packages/command-logger is ignored
> Reproduced this by {{mvn apache-rat:check -Prat}}. Also have the following in my .m2/settings.xml
> {noformat}
>     <pluginGroups>
>         <pluginGroup>org.apache.rat</pluginGroup>
>     </pluginGroups>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)