You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "adamdebreceni (via GitHub)" <gi...@apache.org> on 2023/04/17 13:20:31 UTC
[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request, #1559: MINIFICPP-2105 - Validate ConsumeWindowsEventLogs output/json format
adamdebreceni opened a new pull request, #1559:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1559
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1559: MINIFICPP-2105 - Validate ConsumeWindowsEventLogs output/json format
Posted by "adamdebreceni (via GitHub)" <gi...@apache.org>.
adamdebreceni commented on code in PR #1559:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1559#discussion_r1169551145
##########
extensions/windows-event-log/ConsumeWindowsEventLog.h:
##########
@@ -167,23 +159,21 @@ class ConsumeWindowsEventLog : public core::Processor {
uint64_t batch_commit_size_{};
bool cache_sid_lookups_ = true;
- SMART_ENUM(JSONType,
- (None, "None"),
- (Raw, "Raw"),
- (Simple, "Simple"),
- (Flattened, "Flattened"))
-
- struct OutputFormat {
- bool xml{false};
- bool plaintext{false};
- struct JSON {
- JSONType type{JSONType::None};
-
- explicit operator bool() const noexcept {
- return type != JSONType::None;
- }
- } json;
- } output_;
+ SMART_ENUM(OutputFormatT,
+ (XML, "XML"),
+ (BOTH, "Both"),
+ (PLAINTEXT, "Plaintext"),
+ (JSON, "JSON")
+ );
+
+ SMART_ENUM(JsonFormatT,
+ (RAW, "Raw"),
+ (SIMPLE, "Simple"),
+ (FLATTENED, "Flattened")
+ );
Review Comment:
renamed, also had to rename some properties to avoid collision
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1559: MINIFICPP-2105 - Validate ConsumeWindowsEventLogs output/json format
Posted by "adamdebreceni (via GitHub)" <gi...@apache.org>.
adamdebreceni commented on code in PR #1559:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1559#discussion_r1169545036
##########
extensions/windows-event-log/ConsumeWindowsEventLog.h:
##########
@@ -167,23 +159,21 @@ class ConsumeWindowsEventLog : public core::Processor {
uint64_t batch_commit_size_{};
bool cache_sid_lookups_ = true;
- SMART_ENUM(JSONType,
- (None, "None"),
- (Raw, "Raw"),
- (Simple, "Simple"),
- (Flattened, "Flattened"))
-
- struct OutputFormat {
- bool xml{false};
- bool plaintext{false};
- struct JSON {
- JSONType type{JSONType::None};
-
- explicit operator bool() const noexcept {
- return type != JSONType::None;
- }
- } json;
- } output_;
+ SMART_ENUM(OutputFormatT,
+ (XML, "XML"),
+ (BOTH, "Both"),
+ (PLAINTEXT, "Plaintext"),
+ (JSON, "JSON")
+ );
+
+ SMART_ENUM(JsonFormatT,
+ (RAW, "Raw"),
+ (SIMPLE, "Simple"),
+ (FLATTENED, "Flattened")
+ );
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1559: MINIFICPP-2105 - Validate ConsumeWindowsEventLogs output/json format
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1559:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1559#discussion_r1169009462
##########
extensions/windows-event-log/ConsumeWindowsEventLog.h:
##########
@@ -167,23 +159,21 @@ class ConsumeWindowsEventLog : public core::Processor {
uint64_t batch_commit_size_{};
bool cache_sid_lookups_ = true;
- SMART_ENUM(JSONType,
- (None, "None"),
- (Raw, "Raw"),
- (Simple, "Simple"),
- (Flattened, "Flattened"))
-
- struct OutputFormat {
- bool xml{false};
- bool plaintext{false};
- struct JSON {
- JSONType type{JSONType::None};
-
- explicit operator bool() const noexcept {
- return type != JSONType::None;
- }
- } json;
- } output_;
+ SMART_ENUM(OutputFormatT,
+ (XML, "XML"),
+ (BOTH, "Both"),
+ (PLAINTEXT, "Plaintext"),
+ (JSON, "JSON")
+ );
+
+ SMART_ENUM(JsonFormatT,
+ (RAW, "Raw"),
+ (SIMPLE, "Simple"),
+ (FLATTENED, "Flattened")
+ );
Review Comment:
the linter doesn't like the `;` after the smart enums
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1559: MINIFICPP-2105 - Validate ConsumeWindowsEventLogs output/json format
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1559:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1559#discussion_r1168924977
##########
extensions/windows-event-log/ConsumeWindowsEventLog.h:
##########
@@ -167,23 +159,21 @@ class ConsumeWindowsEventLog : public core::Processor {
uint64_t batch_commit_size_{};
bool cache_sid_lookups_ = true;
- SMART_ENUM(JSONType,
- (None, "None"),
- (Raw, "Raw"),
- (Simple, "Simple"),
- (Flattened, "Flattened"))
-
- struct OutputFormat {
- bool xml{false};
- bool plaintext{false};
- struct JSON {
- JSONType type{JSONType::None};
-
- explicit operator bool() const noexcept {
- return type != JSONType::None;
- }
- } json;
- } output_;
+ SMART_ENUM(OutputFormatT,
+ (XML, "XML"),
+ (BOTH, "Both"),
+ (PLAINTEXT, "Plaintext"),
+ (JSON, "JSON")
+ );
+
+ SMART_ENUM(JsonFormatT,
+ (RAW, "Raw"),
+ (SIMPLE, "Simple"),
+ (FLATTENED, "Flattened")
+ );
Review Comment:
I like this refactoring, and also like the `JsonType` -> `JsonFormat` name change, but I would drop the `T` ending: just `OutputFormat` and `JsonFormat` would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink closed pull request #1559: MINIFICPP-2105 - Validate ConsumeWindowsEventLogs output/json format
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink closed pull request #1559: MINIFICPP-2105 - Validate ConsumeWindowsEventLogs output/json format
URL: https://github.com/apache/nifi-minifi-cpp/pull/1559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org