[jira] [Commented] (FLINK-10608) Add avro files generated by datastream-allround-test to RAT exclusions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656538#comment-16656538 ] 

ASF GitHub Bot commented on FLINK-10608:
----------------------------------------

zentol opened a new pull request #6882: [FLINK-10608][avro] Add exclusion for generated avro files
URL: https://github.com/apache/flink/pull/6882
 
 
   `flink-datastream-allround-test` generates some avro files that are currently not excluded from the RAT check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add avro files generated by datastream-allround-test to RAT exclusions
> ----------------------------------------------------------------------
>
>                 Key: FLINK-10608
>                 URL: https://issues.apache.org/jira/browse/FLINK-10608
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.6.1, 1.7.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>
> With the 1.5.5 and 1.6.2 release-candidates it was discovered that files generated during the build are not covered by the {{apache-rat-plugin}} license-header check.
> As a result the first compilation succeeds but a subsequent one may fail.
> -This is a bit surprising considering that the plugin is executed in the verify phase, which is executed after the compilation and execution of tests.-
> This is because the plugin is only run in the {{flink-parent}} project before anything is compiled. The plugin-configuration is explicitly disables inheritance.
> I'm re-purposing this Jira to add the avro classes to the exclusion list.
> However, in the long term I'd suggest to enable inheritance for the plugin and define the module-specific exclusions in each module respectively. This will allows to run the plugin in the verify phase of each module which would've caught this error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)