You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "dschneider-pivotal (GitHub)" <gi...@apache.org> on 2018/10/21 22:28:47 UTC

[GitHub] [geode] dschneider-pivotal commented on pull request #2676: GEODE-5908: DiskStoreID.compare should compare mostSig, then leastSig

instead of modifying the AbstractRegionEntry unit test I think you should modify or add a unit test for DiskStoreID. That is the class you are modifying and it should make your test much simpler since you can just directly test compareTo and demonstrate that it returns 0 for DiskStoreID that are not equal.

[ Full content available at: https://github.com/apache/geode/pull/2676 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org