You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/03/17 18:18:20 UTC

[GitHub] [calcite] jamesstarr opened a new pull request #2374: [CALCITE-4539] Customization of Metadata Handlers

jamesstarr opened a new pull request #2374:
URL: https://github.com/apache/calcite/pull/2374


   WIP


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] vlsi commented on a change in pull request #2374: [CALCITE-4539] Customization of Metadata Handlers

Posted by GitBox <gi...@apache.org>.
vlsi commented on a change in pull request #2374:
URL: https://github.com/apache/calcite/pull/2374#discussion_r599311770



##########
File path: core/src/main/java/org/apache/calcite/rel/metadata/JaninoRelMetadataProvider.java
##########
@@ -297,14 +296,14 @@ public static JaninoRelMetadataProvider of(RelMetadataProvider provider) {
           .append("_(r, mq");
       argList(buff, method.e)
           .append(");\n")
-          .append("      mq.map.put(r, key, ")
+          .append("      mq.cache.put (r, key, ")

Review comment:
       ```suggestion
             .append("      mq.cache.put(r, key, ")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] jamesstarr commented on pull request #2374: [CALCITE-4539] Customization of Metadata Handlers

Posted by GitBox <gi...@apache.org>.
jamesstarr commented on pull request #2374:
URL: https://github.com/apache/calcite/pull/2374#issuecomment-822814641


   Tracking with https://github.com/apache/calcite/pull/2378


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] jamesstarr closed pull request #2374: [CALCITE-4539] Customization of Metadata Handlers

Posted by GitBox <gi...@apache.org>.
jamesstarr closed pull request #2374:
URL: https://github.com/apache/calcite/pull/2374


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org