You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/10 20:22:06 UTC

[GitHub] dongjoon-hyun commented on a change in pull request #23620: [SPARK-26696][SQL] Makes Dataset encoder public

dongjoon-hyun commented on a change in pull request #23620: [SPARK-26696][SQL] Makes Dataset encoder public
URL: https://github.com/apache/spark/pull/23620#discussion_r255353757
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
 ##########
 @@ -178,7 +178,7 @@ private[sql] object Dataset {
 class Dataset[T] private[sql](
     @transient val sparkSession: SparkSession,
     @DeveloperApi @Unstable @transient val queryExecution: QueryExecution,
-    encoder: Encoder[T])
+    @transient val encoder: Encoder[T])
 
 Review comment:
   Hi, @ssimeonov . Could you update the PR according to the above advice?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org