[GitHub] piiswrong commented on a change in pull request #8413: [WIP] Proof of concept multi processing

[GitBox <gi...@apache.org>]

piiswrong commented on a change in pull request #8413: [WIP] Proof of concept multi processing
URL: https://github.com/apache/incubator-mxnet/pull/8413#discussion_r148606449
 
 

 ##########
 File path: python/mxnet/gluon/data/dataloader.py
 ##########
 @@ -87,10 +168,50 @@ def __init__(self, dataset, batch_size=None, shuffle=False, sampler=None,
                              "not be specified if batch_sampler is specified.")
 
         self._batch_sampler = batch_sampler
+        self._num_workers = num_workers
+        if batchify_fn is None:
+            if num_workers > 0:
+                self._batchify_fn = default_mp_batchify_fn
+            else:
+                self._batchify_fn = default_batchify_fn
+        else:
+            self._batchify_fn = batchify_fn
 
     def __iter__(self):
-        for batch in self._batch_sampler:
-            yield _batchify([self._dataset[idx] for idx in batch])
+        if self._num_workers == 0:
+            for batch in self._batch_sampler:
+                yield self._batchify_fn([self._dataset[idx] for idx in batch])
+            return
+
+        key_queue = Queue()
+        data_queue = Queue(2*self._num_workers)
+
+        workers = []
+        for _ in range(self._num_workers):
 
 Review comment:
   It can be reused. but needs to notify the original process. also memory needs to have the same size every time

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services