You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ti...@apache.org on 2018/01/04 00:36:48 UTC
[2/2] maven-surefire git commit: UnicodeTestNamesIT should be able to
run on Unix/Windows multiple times
UnicodeTestNamesIT should be able to run on Unix/Windows multiple times
Project: http://git-wip-us.apache.org/repos/asf/maven-surefire/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven-surefire/commit/a67f478f
Tree: http://git-wip-us.apache.org/repos/asf/maven-surefire/tree/a67f478f
Diff: http://git-wip-us.apache.org/repos/asf/maven-surefire/diff/a67f478f
Branch: refs/heads/UnicodeTestNamesIT
Commit: a67f478f4c4d09b717646fe1a10a237eceefda45
Parents: 2f16bc7
Author: Tibor17 <ti...@apache.org>
Authored: Thu Jan 4 01:06:04 2018 +0100
Committer: Tibor17 <ti...@apache.org>
Committed: Thu Jan 4 01:35:33 2018 +0100
----------------------------------------------------------------------
.../maven/surefire/its/UnicodeTestNamesIT.java | 35 ++++++++++++--------
1 file changed, 21 insertions(+), 14 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/maven-surefire/blob/a67f478f/surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/UnicodeTestNamesIT.java
----------------------------------------------------------------------
diff --git a/surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/UnicodeTestNamesIT.java b/surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/UnicodeTestNamesIT.java
index 5470a3f..1ad5fe9 100644
--- a/surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/UnicodeTestNamesIT.java
+++ b/surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/UnicodeTestNamesIT.java
@@ -20,40 +20,47 @@ package org.apache.maven.surefire.its;
*/
import java.io.File;
+
import org.apache.maven.surefire.its.fixture.OutputValidator;
import org.apache.maven.surefire.its.fixture.SurefireJUnit4IntegrationTestCase;
import org.apache.maven.surefire.its.fixture.SurefireLauncher;
import org.apache.maven.surefire.its.fixture.TestFile;
-import org.junit.Assert;
-import org.junit.Assume;
import org.junit.Test;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
/**
* Verifies unicode filenames pass through correctly.
- * <br>
- * If the underlying file system turns out not to support unicode, we just fail an assumption.s
*/
public class UnicodeTestNamesIT
- extends SurefireJUnit4IntegrationTestCase
+ extends SurefireJUnit4IntegrationTestCase
{
@Test
public void checkFileNamesWithUnicode()
{
SurefireLauncher unpacked = unpack( "unicode-testnames" );
- File xxyz = new File( unpacked.getUnpackedAt(), "src/test/java/junit/twoTestCases/XXYZTest.java" );
+ File basedir = unpacked.getUnpackedAt();
+
+ unpacked.execute( "clean" );
+
+ File xxyz = new File( basedir, "src/test/java/junit/twoTestCases/XXYZTest.java" );
+ File dest = new File( basedir, "src/test/java/junit/twoTestCases/\u800C\u7D22\u5176\u60C5Test.java" );
+
+ //noinspection ResultOfMethodCallIgnored
+ dest.delete();
+ assertTrue( xxyz.renameTo( dest ) );
- File dest = new File( unpacked.getUnpackedAt(),
- "src/test/java/junit/twoTestCases/\u800C\u7D22\u5176\u60C5Test.java" );
+ assertTrue( dest.exists() );
+ assertFalse( new File( basedir, "src/test/java/junit/twoTestCases/????Test.java" ).exists() );
- Assume.assumeTrue( xxyz.renameTo( dest ) );
- Assume.assumeTrue( dest.exists() );
- Assume.assumeTrue(
- !new File( unpacked.getUnpackedAt(), "src/test/java/junit/twoTestCases/????Test.java" ).exists() );
+ OutputValidator outputValidator =
+ unpacked.executeTest()
+ .assertTestSuiteResults( 2, 0, 0, 0 );
- OutputValidator outputValidator = unpacked.executeTest().assertTestSuiteResults( 2, 0, 0, 0 );
TestFile surefireReportsFile = outputValidator.getSurefireReportsFile( "junit.twoTestCases.而索其情Test.txt" );
- Assert.assertTrue( surefireReportsFile.exists() );
+ assertTrue( surefireReportsFile.exists() );
//surefireReportsFile .assertContainsText( "junit.twoTestCases.\u800C\u7D22\u5176\u60C5Test.txt" );
}