[GitHub] [incubator-iceberg] rominparekh commented on a change in pull request #134: Adding Drop and Rename APIs to Tables interface.

[GitBox <gi...@apache.org>]

rominparekh commented on a change in pull request #134: Adding Drop and Rename APIs to Tables interface.
URL: https://github.com/apache/incubator-iceberg/pull/134#discussion_r267039422
 
 

 ##########
 File path: core/src/main/java/com/netflix/iceberg/hadoop/HadoopTables.java
 ##########
 @@ -66,6 +70,28 @@ public Table load(String location) {
     return new BaseTable(ops, location);
   }
 
+  @Override
+  public void drop(String location) {
+    final Path path = new Path(location);
+    final FileSystem fs = Util.getFS(path, conf);
+    try {
+      fs.delete(path, true);
 
 Review comment:
   can we make the recursive flag as a parameter to the API ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org