[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #610: refactor(c): Simplify CI testing for cpp

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #610:
URL: https://github.com/apache/arrow-adbc/pull/610#discussion_r1189020087


##########
ci/scripts/cpp_test.ps1:
##########
@@ -18,16 +18,8 @@
 
 $ErrorActionPreference = "Stop"
 
-$SourceDir = $Args[0]
-$BuildDir = $Args[1]
-$InstallDir = if ($Args[2] -ne $null) { $Args[2] } else { Join-Path $BuildDir "local/" }
-
-$BuildAll = $env:BUILD_ALL -ne "0"
-$BuildDriverManager = ($BuildAll -and (-not ($env:BUILD_DRIVER_MANAGER -eq "0"))) -or ($env:BUILD_DRIVER_MANAGER -eq "1")
-$BuildDriverFlightSql = ($BuildAll -and (-not ($env:BUILD_DRIVER_FLIGHTSQL -eq "0"))) -or ($env:BUILD_DRIVER_FLIGHTSQL -eq "1")
-$BuildDriverPostgreSQL = ($BuildAll -and (-not ($env:BUILD_DRIVER_POSTGRESQL -eq "0"))) -or ($env:BUILD_DRIVER_POSTGRESQL -eq "1")
-$BuildDriverSqlite = ($BuildAll -and (-not ($env:BUILD_DRIVER_SQLITE -eq "0"))) -or ($env:BUILD_DRIVER_SQLITE -eq "1")
-$BuildDriverSnowflake = ($BuildAll -and (-not ($env:BUILD_DRIVER_SNOWFLAKE -eq "0"))) -or ($env:BUILD_DRIVER_SNOWFLAKE -eq "1")

Review Comment:
   Ah, we do actually want this though, because things like the verification scripts use this so we can build all the projects but only test some of them (since we can't reasonably expect people to have Snowflake credentials, for example)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org