You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by bu...@apache.org on 2006/06/12 23:52:06 UTC

DO NOT REPLY [Bug 39792] New: - ClientJMeterEngine needs synchronization around test tree in 'run'

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39792>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39792

           Summary: ClientJMeterEngine needs synchronization around test
                    tree in 'run'
           Product: JMeter
           Version: 2.1.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Main
        AssignedTo: jmeter-dev@jakarta.apache.org
        ReportedBy: davew@leadfusion.com


I was getting null pointer exceptions when executing remote server tests from 
the command line:
java.lang.NullPointerException
	at org.apache.jmeter.engine.ConvertListeners.addNode
(ConvertListeners.java:53)
	at org.apache.jorphan.collections.HashTree.traverseInto
(HashTree.java:978)
	at org.apache.jorphan.collections.HashTree.traverse(HashTree.java:962)
	at org.apache.jmeter.engine.ClientJMeterEngine.run
(ClientJMeterEngine.java:120)
	at java.lang.Thread.run(Thread.java:534)

Upon tracing it through I discovered that the same HashTree created on line 453 
of JMeter.java was being accessed by two different ClientJMeterEngine threads. 
I added synchronization around the tree in the run method of the 
ClientJMeterEngine and this seemed to resolve the issues:

	public void run() {
		log.info("running clientengine run method");
		testListeners = new SearchByClass(TestListener.class);
        HashTree tree = getTestTree();
        //synchronized here to resolve NPE issue
        synchronized (tree) {
            tree.traverse(testListeners);
        }
		sampleListeners = new ConvertListeners();

		// TODO this is a temporary fix - see bug 23487
		try {
                    //synchronized here to resolve NPE issue
		    synchronized (tree) {
		        tree.traverse(sampleListeners);
		    }
		} catch (IndexOutOfBoundsException e) {
			log.warn("Error replacing sample listeners", e);
		}

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 39792] - ClientJMeterEngine needs synchronization around test tree in 'run'

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39792>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39792


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mdrilling@metamatrix.com




------- Additional Comments From sebb@apache.org  2007-09-01 05:00 -------
*** Bug 35164 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 39792] - ClientJMeterEngine needs synchronization around test tree in 'run'

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39792>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39792


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hsingh@globalstreams.com




------- Additional Comments From sebb@apache.org  2007-09-01 04:57 -------
*** Bug 28028 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 39792] - ClientJMeterEngine needs synchronization around test tree in 'run'

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39792>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39792


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|                            |REMIND




------- Additional Comments From sebb@apache.org  2007-08-20 05:38 -------
Added synchronisation to both accesses in SVN r567668/r567669

See also bug 23487, which this should also fix.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 39792] - ClientJMeterEngine needs synchronization around test tree in 'run'

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39792>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39792


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO




------- Additional Comments From sebb@apache.org  2006-06-12 22:14 -------
What command-line options did you use?

What was the setting of remote_hosts in jmeter.properties - how many hosts were
there?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 39792] - ClientJMeterEngine needs synchronization around test tree in 'run'

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39792>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39792


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




------- Additional Comments From sebb@apache.org  2007-08-20 07:08 -------
Additional testing shows this is now fixed

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org