You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/10/20 11:23:31 UTC
[GitHub] [netbeans] junichi11 opened a new pull request #3257: [NETBEANS-6087] Use the refactoring feature for private members of trait instead of the instant renamer
junichi11 opened a new pull request #3257:
URL: https://github.com/apache/netbeans/pull/3257
- https://issues.apache.org/jira/browse/NETBEANS-6087
- Classes can also use private members of traits. If the declaration of the member is in another file, only member names in the same file are renamed using the instant renamer. So, we have to use the refactoring feature instead of it.
#### Screenshots


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #3257: [NETBEANS-6087] Use the refactoring feature for private members of trait instead of the instant renamer
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #3257:
URL: https://github.com/apache/netbeans/pull/3257#discussion_r732675934
##########
File path: php/php.refactoring/test/unit/src/org/netbeans/modules/refactoring/php/findusages/FindUsagesTestBase.java
##########
@@ -60,7 +67,8 @@ private String getTestResult(final String exactFileName, final String caretLine)
caretOffset = -1;
}
final String[] result = new String[1];
- ParserManager.parse(Collections.singleton(testSource), new UserTask() {
+ // wait for the scan to finish
+ Future<Void> future = ParserManager.parseWhenScanFinished(Collections.singleton(testSource), new UserTask() {
Review comment:
The following error may occur. So, wait for the scan to finish.
<details>
<summary>log</summary>
```
Testcase: testInterfaces_01(org.netbeans.modules.refactoring.php.findusages.WhereUsedSupportTest): Caused an ERROR
null
org.netbeans.modules.parsing.spi.ParseException
at org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:186)
at org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:81)
at org.netbeans.modules.refactoring.php.findusages.FindUsagesTestBase.getTestResult(FindUsagesTestBase.java:69)
at org.netbeans.modules.refactoring.php.findusages.FindUsagesTestBase.findUsages(FindUsagesTestBase.java:48)
at org.netbeans.modules.refactoring.php.findusages.WhereUsedSupportTest.testInterfaces_01(WhereUsedSupportTest.java:200)
at org.netbeans.junit.NbTestCase.access$200(NbTestCase.java:77)
at org.netbeans.junit.NbTestCase$2.doSomething(NbTestCase.java:476)
at org.netbeans.junit.NbTestCase$1Guard.run(NbTestCase.java:402)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NullPointerException
at org.netbeans.modules.refactoring.php.findusages.FindUsagesTestBase$1.run(FindUsagesTestBase.java:78)
at org.netbeans.modules.parsing.impl.TaskProcessor.callUserTask(TaskProcessor.java:586)
at org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:130)
at org.netbeans.modules.parsing.api.ParserManager$UserTaskAction.run(ParserManager.java:114)
at org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:181)
at org.netbeans.modules.parsing.impl.TaskProcessor$2.call(TaskProcessor.java:178)
at org.netbeans.modules.masterfs.filebasedfs.utils.FileChangedManager.priorityIO(FileChangedManager.java:153)
at org.netbeans.modules.masterfs.providers.ProvidedExtensions.priorityIO(ProvidedExtensions.java:335)
at org.netbeans.modules.parsing.nb.DataObjectEnvFactory.runPriorityIO(DataObjectEnvFactory.java:118)
at org.netbeans.modules.parsing.impl.Utilities.runPriorityIO(Utilities.java:67)
at org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:178)
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik merged pull request #3257: [NETBEANS-6087] Use the refactoring feature for private members of trait instead of the instant renamer
Posted by GitBox <gi...@apache.org>.
tmysik merged pull request #3257:
URL: https://github.com/apache/netbeans/pull/3257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3257: [NETBEANS-6087] Use the refactoring feature for private members of trait instead of the instant renamer
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3257:
URL: https://github.com/apache/netbeans/pull/3257#issuecomment-947770608
@tmysik
I've just restarted the jobs, so, let's merge it tomorrow :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #3257: [NETBEANS-6087] Use the refactoring feature for private members of trait instead of the instant renamer
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #3257:
URL: https://github.com/apache/netbeans/pull/3257#issuecomment-947764540
@junichi11
There are some CI failures - do you want to review them? Or can I merge this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists