You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "jeanouii (via GitHub)" <gi...@apache.org> on 2026/02/12 21:28:26 UTC
[PR] Replace Thread.sleep with Wait.waitFor in FailoverClusterTest [activemq]
jeanouii opened a new pull request, #1679:
URL: https://github.com/apache/activemq/pull/1679
Thread.sleep(3000) is unreliable on slow CI machines for waiting on cluster formation and client rebalancing. Replace all sleep-based synchronization with Wait.waitFor polling:
- testClusterConnectedAfterClients: poll for clients on multiple brokers
- testClusterURIOptionsStrip: same polling for client rebalance
- testClusterConnectedBeforeClients: poll for bridge formation, then poll for client failover after broker stop
This also fixes AutoFailoverClusterTest which inherits these methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Replace Thread.sleep with Wait.waitFor in FailoverClusterTest [activemq]
Posted by "rahul-chakradhari (via GitHub)" <gi...@apache.org>.
rahul-chakradhari commented on PR #1679:
URL: https://github.com/apache/activemq/pull/1679#issuecomment-3901254158
Hi @jeanouii,
I am an Outreachy applicant for the May 2026 cohort and a Java developer. I’ve been exploring the codebase and I see you are replacing Thread.sleep with Wait.waitFor in FailoverClusterTest.
Could you please guide me if I can take this up or if there’s a similar 'Good First Issue' I can start with? I'm eager to make my initial contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Replace Thread.sleep with Wait.waitFor in FailoverClusterTest [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1679:
URL: https://github.com/apache/activemq/pull/1679#issuecomment-3901664007
@rahul-chakradhari you can start by testing locally and identify flaky tests and fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Replace Thread.sleep with Wait.waitFor in FailoverClusterTest [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #1679:
URL: https://github.com/apache/activemq/pull/1679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Replace Thread.sleep with Wait.waitFor in FailoverClusterTest [activemq]
Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii commented on PR #1679:
URL: https://github.com/apache/activemq/pull/1679#issuecomment-3901590483
Hi,
First, thank you for showing up and be eager to help. I've started the same way, all of us pretty much.
The build stability is an issue, especially since we moved to Github Actions.
My usual approach is to monitor the builds (quick, nightly, or on-demand) on Github Actions and then create an issue to start investigating. Most of the time it's a race condition (Thread.sleep or similar). The test needs fixing. I've seen a few issues in the production code, but not much.
If you want to look at the test failures and send an email to dev@activemq.apache.org we can better guide you.
If you can't find test failures, I'm happy to take a first look and create the JIRA issues for you to dig in.
Let us know and welcome
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact