You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/27 02:27:53 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #8674: [charts] Chart specific time controls

john-bodley opened a new pull request #8674: [charts] Chart specific time controls
URL: https://github.com/apache/incubator-superset/pull/8674
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   This PR ensures that only the relevant time widgets are included depending on the chart type. Previously the granularity logic was shown even if the chart type did not support granularity, i.e., non-timeseries charts. 
   
   This provides a number of benefits including: 
   
   1. Improved UX: It's not apparent to the user that these controls have no impact on the chart.
   2. Improved performance: The controls serve as inputs to the cache and thus the cache is invalidated when these erroneous options are changed. 
   3. Cleaner form-data: The impetus for this change stemmed from a project migrating charts from Druid NoSQL to SQL where there isn't a 1:1 mapping for the time parameters. The erroneous values could deem a chart is non-migratable even though in theory is was.
   
   Additionally this PR also removes the time controls for chart types which don't support time filtering, i.e., iFrame, Markup, etc.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before 
   
   ![Screen Shot 2019-11-26 at 6 26 46 PM](https://user-images.githubusercontent.com/4567245/69688249-5bc65300-107a-11ea-94a3-3e8faaadf730.png)
   
   #### After
   
   ![Screen Shot 2019-11-26 at 6 24 49 PM](https://user-images.githubusercontent.com/4567245/69688200-376a7680-107a-11ea-9fe8-4bb33514860d.png)
   
   ### TEST PLAN
   
   CI.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   Fixes #2750.
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   to: @etr2460 @graceguo-supercat @mistercrunch @willbarrett @villebro 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org