You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/09 22:58:25 UTC
[GitHub] [arrow] wesm opened a new pull request #7698: ARROW-9380: [C++] Fix Filter crashes and bug in kernels with NullHandling::OUTPUT_NOT_NULL
wesm opened a new pull request #7698:
URL: https://github.com/apache/arrow/pull/7698
A few interrelated fixes:
* The `is_null` kernel was returning a slightly malformed `ArrayData` with the null_count set to -1 even though the validity bitmap is null.
* Adds `ArrayData::MayHaveNulls` function to help with checking for the above problem
* Make filter implementation robust to the previous bullet point (no validity bitmap but atomic null count non-zero)
* Argument arity was not being checked in metafunctions, so this is now checked in a single place at `MetaFunction::Execute`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7698: ARROW-9380: [C++] Fix Filter crashes and bug in kernels with NullHandling::OUTPUT_NOT_NULL
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7698:
URL: https://github.com/apache/arrow/pull/7698#issuecomment-656392177
https://issues.apache.org/jira/browse/ARROW-9380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7698: ARROW-9380: [C++] Fix Filter crashes and bug in kernels with NullHandling::OUTPUT_NOT_NULL
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7698:
URL: https://github.com/apache/arrow/pull/7698
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7698: ARROW-9380: [C++] Fix Filter crashes and bug in kernels with NullHandling::OUTPUT_NOT_NULL
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7698:
URL: https://github.com/apache/arrow/pull/7698#issuecomment-656390655
@nealrichardson thanks for finding these issues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7698: ARROW-9380: [C++] Fix Filter crashes and bug in kernels with NullHandling::OUTPUT_NOT_NULL
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7698:
URL: https://github.com/apache/arrow/pull/7698#issuecomment-656421460
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org