[GitHub] [mynewt-core] amrbekhit edited a comment on issue #1670: Implement low-power support in the LoRa stack

[GitBox <gi...@apache.org>]

amrbekhit edited a comment on issue #1670: Implement low-power support in the LoRa stack
URL: https://github.com/apache/mynewt-core/pull/1670#issuecomment-486929962
 
 
   Hi @wes3 as requested I've removed the HFXO changes to hal_system.c and hal_timer.c and will add these as a separate pull request. **EDIT** the new pull request can be found [here](https://github.com/apache/mynewt-core/pull/1783).
   
   I've made some changes to the low power callbacks - since the LoRa code can turn the timer off itself using `hal_timer_deinit`, I've removed the `lora_low_power_enter` callback function and renamed `lora_low_power_exit` to `lora_bsp_enable_mac_timer`. BSPs now only need to implement `lora_bsp_enable_mac_timer`.
   
   I've also modified the b-l072z-lrwan1 and telee02 BSPs to implement `lora_bsp_enable_mac_timer`. Travis CI now builds find and this pull request passes all checks.
   
   Hopefully this can now be merged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services