[GitHub] [accumulo] cshannon commented on a diff in pull request #3122: Add Constant for Zookeeper user Path; Improve naming standardization.

[GitBox <gi...@apache.org>]

cshannon commented on code in PR #3122:
URL: https://github.com/apache/accumulo/pull/3122#discussion_r1051105863


##########
server/base/src/main/java/org/apache/accumulo/server/ServerContext.java:
##########
@@ -113,6 +114,7 @@ private ServerContext(ServerInfo info) {
     serverDirs = info.getServerDirs();
 
     propStore = memoize(() -> ZooPropStore.initialize(getInstanceID(), getZooReaderWriter()));
+    zkUserPath = memoize(() -> Constants.ZROOT + "/" + getInstanceID() + Constants.ZUSERS);

Review Comment:
   I don't think you need to use memoize here. That's for lazy loading instances with a supplier to load when needed but the zkUserPath is just a final String value so it should be fine to just use directly, ie `zkUserPath = Constants.ZROOT + "/" + getInstanceID() + Constants.ZUSERS;`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org