[jira] [Work logged] (HIVE-25362) LLAP: ensure tasks with locality have a chance to adjust delay

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-25362?focusedWorklogId=635359&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635359 ]

ASF GitHub Bot logged work on HIVE-25362:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Aug/21 16:12
            Start Date: 06/Aug/21 16:12
    Worklog Time Spent: 10m 
      Work Description: pgaref commented on a change in pull request #2513:
URL: https://github.com/apache/hive/pull/2513#discussion_r684351582



##########
File path: llap-tez/src/test/org/apache/hadoop/hive/llap/tezplugins/TestLlapTaskSchedulerService.java
##########
@@ -904,6 +904,48 @@ private void forceLocalityTest1(boolean forceLocality) throws IOException, Inter
     }
   }
 
+  @Test(timeout = 10000)

Review comment:
       Sure, TaskInfo can not be mocked directly so had to play with the adjustedLocalityDelay.
   This should do though




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 635359)
    Time Spent: 40m  (was: 0.5h)

> LLAP: ensure tasks with locality have a chance to adjust delay
> --------------------------------------------------------------
>
>                 Key: HIVE-25362
>                 URL: https://issues.apache.org/jira/browse/HIVE-25362
>             Project: Hive
>          Issue Type: Sub-task
>          Components: llap
>            Reporter: Panagiotis Garefalakis
>            Assignee: Panagiotis Garefalakis
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> HIVE-24914 introduced a short-circuit optimization when all nodes are busy returning DELAYED_RESOURCES and reseting locality delay for a given tasks.
> However, this may prevent tasks from adjusting their locality delay and being added to the DelayQueue leading sometimes to missed locality chances when all LLap resources are fully utilized.
> To address the issue we should handle the two cases separately.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)