You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/10 08:40:17 UTC
[GitHub] [tvm] d-smirnov opened a new pull request #8008: [CI] Added llvm-12 to ubuntu1804_install_llvm.sh
d-smirnov opened a new pull request #8008:
URL: https://github.com/apache/tvm/pull/8008
This PR adds llvm-12 to ubuntu1804_install_llvm.sh. This is needed as llvm, prior to 11.1.0, contains an issue which affects X86 backend and virtually prevents some cases of vectorization done in TVM (https://github.com/llvm/llvm-project/commit/c7b54a196e1363cbe43122f01a728cd71fa1686a).
To reproduce this issue locally one can use following publicly available network https://github.com/ARM-software/ML-zoo/blob/master/models/keyword_spotting/ds_cnn_small/tflite_int8/ds_cnn_s_quantized.tflite
Command line:
`tvmc compile --target llvm ds_cnn_s_quantized.tflite `
will fail in attempt to perform `combineMul ` on `t20: v12i32 = mul nsw t19, t6` due to missing MVT of v6i32 (which in fact should be EVT, not MVT) on llvm versions prior 11.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on a change in pull request #8008: [CI] Added llvm-12 to ubuntu1804_install_llvm.sh
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #8008:
URL: https://github.com/apache/tvm/pull/8008#discussion_r629402407
##########
File path: docker/install/ubuntu1804_install_llvm.sh
##########
@@ -36,10 +36,15 @@ echo deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic-11 main\
echo deb-src http://apt.llvm.org/bionic/ llvm-toolchain-bionic-11 main\
>> /etc/apt/sources.list.d/llvm.list
+echo deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic-12 main\
+ >> /etc/apt/sources.list.d/llvm.list
+echo deb-src http://apt.llvm.org/bionic/ llvm-toolchain-bionic-12 main\
+ >> /etc/apt/sources.list.d/llvm.list
+
echo deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic main\
>> /etc/apt/sources.list.d/llvm.list
echo deb-src http://apt.llvm.org/bionic/ llvm-toolchain-bionic main\
>> /etc/apt/sources.list.d/llvm.list
wget -q -O - http://apt.llvm.org/llvm-snapshot.gpg.key|sudo apt-key add -
-apt-get update && apt-get install -y llvm-9 llvm-10 llvm-11 clang-9 libclang-9-dev clang-10 libclang-10-dev clang-11 libclang-11-dev
+apt-get update && apt-get install -y llvm-9 llvm-10 llvm-11 llvm-12 clang-9 libclang-9-dev clang-10 libclang-10-dev clang-11 libclang-11-dev clang-12 libclang-12-dev
Review comment:
Given we usually maintain the last 3 version, I think we can remove version 9 in the same PR, keeping only 10, 11 and 12?
Also cc @tqchen @jroesch for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on a change in pull request #8008: [CI] Added llvm-12 to ubuntu1804_install_llvm.sh
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #8008:
URL: https://github.com/apache/tvm/pull/8008#discussion_r631007359
##########
File path: docker/install/ubuntu1804_install_llvm.sh
##########
@@ -36,10 +36,15 @@ echo deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic-11 main\
echo deb-src http://apt.llvm.org/bionic/ llvm-toolchain-bionic-11 main\
>> /etc/apt/sources.list.d/llvm.list
+echo deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic-12 main\
+ >> /etc/apt/sources.list.d/llvm.list
+echo deb-src http://apt.llvm.org/bionic/ llvm-toolchain-bionic-12 main\
+ >> /etc/apt/sources.list.d/llvm.list
+
echo deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic main\
>> /etc/apt/sources.list.d/llvm.list
echo deb-src http://apt.llvm.org/bionic/ llvm-toolchain-bionic main\
>> /etc/apt/sources.list.d/llvm.list
wget -q -O - http://apt.llvm.org/llvm-snapshot.gpg.key|sudo apt-key add -
-apt-get update && apt-get install -y llvm-9 llvm-10 llvm-11 clang-9 libclang-9-dev clang-10 libclang-10-dev clang-11 libclang-11-dev
+apt-get update && apt-get install -y llvm-9 llvm-10 llvm-11 llvm-12 clang-9 libclang-9-dev clang-10 libclang-10-dev clang-11 libclang-11-dev clang-12 libclang-12-dev
Review comment:
Let us first keep all, we might need to update testcase first to change the llvm-config before we can drop 9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #8008: [CI] Added llvm-12 to ubuntu1804_install_llvm.sh
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #8008:
URL: https://github.com/apache/tvm/pull/8008#issuecomment-840099590
LGTM, let's merge to get this into #7995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #8008: [CI] Added llvm-12 to ubuntu1804_install_llvm.sh
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8008:
URL: https://github.com/apache/tvm/pull/8008#issuecomment-839718869
Also cc @areusch for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #8008: [CI] Added llvm-12 to ubuntu1804_install_llvm.sh
Posted by GitBox <gi...@apache.org>.
areusch merged pull request #8008:
URL: https://github.com/apache/tvm/pull/8008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on a change in pull request #8008: [CI] Added llvm-12 to ubuntu1804_install_llvm.sh
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #8008:
URL: https://github.com/apache/tvm/pull/8008#discussion_r631016149
##########
File path: docker/install/ubuntu1804_install_llvm.sh
##########
@@ -36,10 +36,15 @@ echo deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic-11 main\
echo deb-src http://apt.llvm.org/bionic/ llvm-toolchain-bionic-11 main\
>> /etc/apt/sources.list.d/llvm.list
+echo deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic-12 main\
+ >> /etc/apt/sources.list.d/llvm.list
+echo deb-src http://apt.llvm.org/bionic/ llvm-toolchain-bionic-12 main\
+ >> /etc/apt/sources.list.d/llvm.list
+
echo deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic main\
>> /etc/apt/sources.list.d/llvm.list
echo deb-src http://apt.llvm.org/bionic/ llvm-toolchain-bionic main\
>> /etc/apt/sources.list.d/llvm.list
wget -q -O - http://apt.llvm.org/llvm-snapshot.gpg.key|sudo apt-key add -
-apt-get update && apt-get install -y llvm-9 llvm-10 llvm-11 clang-9 libclang-9-dev clang-10 libclang-10-dev clang-11 libclang-11-dev
+apt-get update && apt-get install -y llvm-9 llvm-10 llvm-11 llvm-12 clang-9 libclang-9-dev clang-10 libclang-10-dev clang-11 libclang-11-dev clang-12 libclang-12-dev
Review comment:
Understood.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org